Revert "OSAC-2932: [UI] Catalog management list page with resource type tabs" - #108
Merged
openshift-merge-bot[bot] merged 2 commits intoJul 30, 2026
Conversation
…pe tabs" (osac-project#100) This reverts commit 53f774c, reversing changes made to afbc45d391851d2cea2417e29fbc27977c8ff8d8. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Elay Aharoni <elayaha@gmail.com>
|
@ElayAharoni: This pull request references OSAC-2932 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (33)
💤 Files with no reviewable changes (25)
WalkthroughChangesRemoves the admin catalog route, management pages, private catalog hooks, scope/status UI, and role-specific navigation. Public catalog types and bare-metal hook usage are simplified, with related tests, helpers, icons, and translations removed. Catalog management removal
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
After reverting OSAC-2932 (osac-project#100), the "Catalog management" nav item still pointed at an empty placeholder page (the OSAC-2931 scaffold that osac-project#100 built on top of). Remove the nav item, the now-empty Administration nav section, the /admin/catalog route, and the AdminCatalogRoutes placeholder so nothing links to dead UI. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Elay Aharoni <elayaha@gmail.com>
ElayAharoni
marked this pull request as ready for review
July 30, 2026 09:54
ElayAharoni
requested review from
batzionb and
rawagner
and removed request for
jhernand and
omer-vishlitzky
July 30, 2026 09:54
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
batzionb
approved these changes
Jul 30, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batzionb, ElayAharoni The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jul 30, 2026
d74aaaf
into
osac-project:main
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git revert -m 1 53f774c), no conflicts./admin/catalogroute, and theAdminCatalogRoutesplaceholder page. Without this, the nav would still show a "Catalog management" link leading to a blank page.Test plan
pnpm --filter @osac/app-frontend run build— passespnpm test— passes (one unrelated pre-existing flaky test inClusterCreatePage.test.tsx, untouched by this change, confirmed passing in isolation)pnpm lint(including i18n sync check) — passesAssisted-by: Claude Code noreply@anthropic.com
Summary by CodeRabbit
Removed Features
Updates