Skip to content

feat: support EdDSA signing algorithms#1203

Open
taisph wants to merge 1 commit into
ory:masterfrom
taisph:feat-add-eddsa
Open

feat: support EdDSA signing algorithms#1203
taisph wants to merge 1 commit into
ory:masterfrom
taisph:feat-add-eddsa

Conversation

@taisph

@taisph taisph commented Nov 29, 2024

Copy link
Copy Markdown

Fixes: #1191

@CLAassistant

CLAassistant commented Nov 29, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@taisph taisph marked this pull request as ready for review January 31, 2025 06:49
@taisph taisph requested review from a team and aeneasr as code owners January 31, 2025 06:49

@amcnamara amcnamara left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this patch against v25.4.0 and it worked as expected. I would like to see this merged into master since hydra is vending eddsa tokens, it's extremely confusing that they'd break here.

@gtomitsuka

Copy link
Copy Markdown

what do you think @hperl? this would be huge for us

@tacurran

Copy link
Copy Markdown
Member

@aeneasr , this LGTM - would you approve please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This request object uses unsupported signing algorithm "EdDSA"

6 participants