Merge headers into 'finalResults' - #39
Conversation
filippomc
left a comment
filippomc
left a comment
There was a problem hiding this comment.
Sorry I can't get what's the purpose of this pr. Is there any issue I can look to?
@filippomc It's related to issue #435 in geppetto-vfb VirtualFlyBrain/geppetto-vfb#435 |
Ohhh I filed that issue :D @tarelli what do you think about having a specific issue in the geppetto repo in cases like this? Parhaps the PR may also be enough, if properly described and put in the project. In that case, I'd name the branch something like |
| boolean first = true; | ||
| for(QueryResults result : results.keySet()) | ||
| { | ||
| if(finalResults.getHeader().isEmpty()) |
There was a problem hiding this comment.
@jrmartin why two PRs target the same piece of code? Are the both based on development or there is a sequence here? I foresee conflicts
|
@filippomc it's good to have a separate issue but it needs to be clear what it is as it refers to the platform. The original application bug might (should in general) be domain specific but here it needs to become something we understand in more generic terms. So we need to take the time to write that down and reference the application bug as an example of how it could manifest. cc @jrmartin |
4 participants
No description provided.