NE-2788: add haproxy28 weekly nightly periodic jobs - #83066
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gcs278: This pull request references NE-2788 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe change adds AWS test configurations for HAProxy 2.8. It covers standard, serial, upgrade, FIPS, and stable-version upgrade-conformance workflows. ChangesAWS HAProxy 2.8 testing
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 3263-3321: Regenerate the missing periodic Prow jobs by running
make update, covering the source entries in
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
lines 3263-3321 and
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml
lines 234-248, then commit the resulting changes to
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 440a0fdc-40e4-4628-bc13-8d296ba55680
📒 Files selected for processing (2)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yamlci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
openshift-merge-bot
Bot
added
the
rehearsals-ack
52c15f3 to
eaef395
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
/retest |
|
/pj-rehearse |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
/hold We need an update to https://github.com/openshift/origin/blob/main/test/extended/operators/operators.go#L99 to add an exception for haproxy28 upgradeable=false condition which is expected |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/pj-rehearse |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
I need to wait for the next accepted nightly for openshift/origin#31494 to take effect |
|
/pj-rehearse |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28 |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-fips-haproxy28 |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-haproxy28-2of2 |
|
/pj-rehearse |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Just step reorder. /lgtm |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28 |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/rehearse-83066-periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28'
echo '=== Job history page ==='
curl -fsSL "$base" | sed -n '1,240p'
echo
echo '=== Object listing candidates ==='
for url in \
'https://storage.googleapis.com/test-platform-results/pr-logs/directory/rehearse-83066-periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28/' \
'https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/directory/rehearse-83066-periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28/'
do
echo "--- $url"
curl -fsSL "$url" | sed -n '1,160p' || true
doneLength of output: 13151 🏁 Script executed: #!/bin/bash
set -euo pipefail
job='rehearse-83066-periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28'
build='2087221719243689984'
root="https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/83066/$job/$build"
spyglass="https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/83066/$job/$build"
echo '=== Spyglass page: artifact links ==='
curl -fsSL "$spyglass" |
grep -Eo 'href="[^"]+"|[^<]{0,120}(Fail|FAIL|Error|ERROR|upgradeable|Upgradeable|haproxy|HAProxy)[^<]{0,160}' |
sed -n '1,260p' || true
echo
echo '=== GCS artifact index ==='
curl -fsSL "$root/" | sed -n '1,360p'
echo
echo '=== Top-level build log failure excerpts ==='
curl -fsSL "$root/build-log.txt" |
grep -Ein -C 4 '(^|[^[:alnum:]])(fail|failure|error|upgradeable|haproxy|panic|timed out|timeout)([^[:alnum:]]|$)' |
tail -n 360 || true
echo
echo '=== JUnit failure excerpts, if present ==='
curl -fsSL "$root/artifacts/junit_operator.xml" 2>/dev/null |
grep -Ein -C 3 '(failure|error|upgradeable|haproxy)' |
tail -n 160 || trueLength of output: 60645 🏁 Script executed: #!/bin/bash
set -euo pipefail
job='rehearse-83066-periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28'
for build in 2085462306837237760 2086862157772754944 2087177198606749696 2087221719243689984; do
url="https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/83066/$job/$build/build-log.txt"
echo "===== Build $build ====="
curl -fsSL "$url" |
grep -Ein -C 2 \
'Bootstrap failed to complete|bootkube service failed|etcd-bootstrap|Failed waiting for Kubernetes API|Step .*ipi-install-install failed|upgradeable=false|Upgradeable' |
tail -n 80 || true
doneLength of output: 17351
Each run fails in:
The initial AWS 4.22 cluster does not complete bootstrap. The common error is: The installer container then exits with code This is not the expected HAProxy 2.8 The top-level logs do not contain the underlying You are interacting with an AI system. |
Add five weekly nightly periodic jobs to validate HAProxy 2.8 (the non-default, pinnable version) against the 5.0 release payload: - e2e-aws-ovn-haproxy28 (conformance) - e2e-aws-ovn-serial-haproxy28 (serial, 2 shards) - e2e-aws-ovn-upgrade-haproxy28 (z-stream upgrade) - e2e-aws-ovn-fips-haproxy28 (FIPS conformance) - e2e-aws-ovn-upgrade-from-stable-haproxy28 (4.22 to 5.0 upgrade) All jobs run weekly on AWS using the ingress-conf-haproxy-version CI step to set HAProxy 2.8 as the cluster-wide default post-install. HAProxy behavior is platform-agnostic so single-platform coverage is sufficient. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0f3416c to
a6e7004
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade-from-stable-haproxy28 |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
Another step reorder. /lgtm |
|
@jcmoraisjr can you provide one last lgtm please? I've tested all of the periodics, and got everything to pass at least once. |
|
oh nvm you are too quick thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, jcmoraisjr, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary
Add five weekly nightly periodic jobs to validate HAProxy 2.8 (the non-default, pinnable version) against the 5.0 release payload, as described in the enhancement test plan.
e2e-aws-ovn-haproxy28__nightly-5.0.yamle2e-aws-ovn-serial-haproxy28__nightly-5.0.yamle2e-aws-ovn-upgrade-haproxy28__nightly-5.0.yamle2e-aws-ovn-fips-haproxy28__nightly-5.0.yamle2e-aws-ovn-upgrade-from-stable-haproxy28__nightly-5.0-upgrade-from-stable-4.22.yamlWhy
The multi-HAProxy version feature (NE-2215) supports HAProxy 2.8 as a pinnable alternative to the default 3.2. Currently only optional presubmits exist for haproxy28 — TRT requires nightly periodics for proper CI signal.
All jobs run on AWS only — HAProxy behavior is platform-agnostic. FIPS is included because HAProxy 2.8 uses OpenSSL 1.1/pcre1 while 3.2 uses OpenSSL 3.x/pcre2, which may behave differently in FIPS mode.
Jobs use the
ingress-conf-haproxy-versionCI step to annotateingresses.config.openshift.io/clusterpost-install, setting HAProxy 2.8 as the default for all IngressControllers.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Adds five weekly AWS jobs for the OpenShift 5.0 release payload. The jobs validate HAProxy 2.8 through conformance, serial, upgrade, FIPS conformance, and stable 4.22 upgrade workflows.
Each job sets HAProxy 2.8 as the default for all IngressControllers and uses AWS IPI installation with the applicable upgrade, observer, and FIPS checks.