Skip to content

OCPBUGS-98102: Update Azure install-config for DualStack - #81697

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
sadasu:fix-azure-dualstack-jobs
Jul 10, 2026
Merged

OCPBUGS-98102: Update Azure install-config for DualStack#81697
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
sadasu:fix-azure-dualstack-jobs

Conversation

@sadasu

@sadasu sadasu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step.

Summary by CodeRabbit

Updated OpenShift CI’s Azure IPI step-registry configuration so that DualStack installs use the recommended IPv6 /56 prefix. Specifically, when IP_FAMILY is enabled, the generated install-config.yaml now sets the IPv6 machineNetwork CIDR from fd00::/64 to fd00::/56, affecting the Azure network settings for DualStack cluster provisioning.

Also refreshed the Azure step-registry ownership metadata by updating the OWNERS approvers list and mirroring that change across the related Azure identity/chain/ref and sharednetwork ref/chain metadata.

When DualStack is enabled, make the IPv6 machine network's
address prefix to be the recommended /56 in the install-config
customization step.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-98102, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 37280278-8013-438c-aa46-5b222d92883b

📥 Commits

Reviewing files that changed from the base of the PR and between d12779f and 962af4f.

📒 Files selected for processing (6)
  • ci-operator/step-registry/ipi/conf/azure/OWNERS
  • ci-operator/step-registry/ipi/conf/azure/identity/ipi-conf-azure-identity-ref.metadata.json
  • ci-operator/step-registry/ipi/conf/azure/ipi-conf-azure-chain.metadata.json
  • ci-operator/step-registry/ipi/conf/azure/ipi-conf-azure-ref.metadata.json
  • ci-operator/step-registry/ipi/conf/azure/sharednetwork/ipi-conf-azure-sharednetwork-chain.metadata.json
  • ci-operator/step-registry/ipi/conf/azure/sharednetwork/ipi-conf-azure-sharednetwork-ref.metadata.json
✅ Files skipped from review due to trivial changes (3)
  • ci-operator/step-registry/ipi/conf/azure/identity/ipi-conf-azure-identity-ref.metadata.json
  • ci-operator/step-registry/ipi/conf/azure/OWNERS
  • ci-operator/step-registry/ipi/conf/azure/sharednetwork/ipi-conf-azure-sharednetwork-chain.metadata.json

Walkthrough

Azure dual-stack networking now uses an IPv6 machineNetwork CIDR of fd00::/56, and Azure configuration ownership lists replace two approvers with two new entries.

Changes

Azure configuration updates

Layer / File(s) Summary
Update dual-stack IPv6 network CIDR
ci-operator/step-registry/ipi/conf/azure/ipi-conf-azure-commands.sh
Changes the generated dual-stack IPv6 machineNetwork CIDR from fd00::/64 to fd00::/56.
Refresh Azure approver metadata
ci-operator/step-registry/ipi/conf/azure/OWNERS, ci-operator/step-registry/ipi/conf/azure/**/*.metadata.json
Replaces jianlinliu and yunjiang29 with rna-afk and jhixson74 in Azure approver lists.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: updating Azure install-config behavior for DualStack.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes Azure step-registry config/OWNERS files; no Ginkgo It/Describe/Context/When titles appear in the changed files.
Test Structure And Quality ✅ Passed Diff touches only Azure shell/OWNERS metadata files; no *_test.go or Ginkgo tests changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only changes Azure step-registry config/OWNERS metadata and a CIDR value, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes Azure install-config and OWNERS metadata, so SNO-specific test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only Azure install-config IPv6 CIDR and OWNERS metadata changed; no pod affinity, node selectors, replicas, or topology-aware scheduling logic was added.
Ote Binary Stdout Contract ✅ Passed The only code change is a heredoc CIDR tweak in a shell step; no main/init/TestMain/BeforeSuite stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only changes Azure install-config networking CIDR and owners metadata, with no external connectivity or IPv4-only test logic.
No-Weak-Crypto ✅ Passed PR only updates OWNERS metadata; the actual diff contains no crypto code or weak algorithm/comparison usage.
Container-Privileges ✅ Passed PASS: The PR only touches Azure step-registry shell/metadata files; no changed file contains privileged:true, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed No passwords, tokens, PII, hostnames, or customer data were logged; the only new log is a generic IP_FAMILY status line.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rna-afk

rna-afk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
openshift-ci Bot requested review from smg247 and xueqzhan July 9, 2026 15:58
@rna-afk

rna-afk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rna-afk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rna-afk

rna-afk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@tthvo

tthvo commented Jul 9, 2026

Copy link
Copy Markdown
Member

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tthvo

tthvo commented Jul 9, 2026

Copy link
Copy Markdown
Member

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@tthvo: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@tthvo

tthvo commented Jul 9, 2026

Copy link
Copy Markdown
Member

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@tthvo: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@tthvo

tthvo commented Jul 9, 2026

Copy link
Copy Markdown
Member

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rna-afk

rna-afk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv6-primary-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rna-afk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rna-afk: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@sadasu

sadasu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@sadasu

sadasu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@rna-afk the failures in the dualstack jobs are expected. This PR is ready to merge as is to continue our testing.

@rna-afk

rna-afk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

sounds good

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@sadasu

sadasu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@sadasu
sadasu force-pushed the fix-azure-dualstack-jobs branch from d12779f to 962af4f Compare July 10, 2026 16:27
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sadasu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-etcd-operator-main-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-5.1-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-5.0-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.23-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.22-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.21-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.20-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.19-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.18-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.17-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.15-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.14-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.13-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.12-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.11-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.10-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.9-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.8-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.7-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.6-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.5-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.4-e2e-azure openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-main-e2e-azure-ovn-etcd-scaling openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-5.1-e2e-azure-ovn-etcd-scaling openshift/cluster-etcd-operator presubmit Registry content changed

A total of 4915 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rna-afk

rna-afk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@sadasu

sadasu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

The dualstack jobs are not expected to pass and the other jobs are unaffected by this change.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2026
@patrickdillon

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, rna-afk, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/api/release-4.22/e2e-azure 6bf0096 link unknown /pj-rehearse pull-ci-openshift-api-release-4.22-e2e-azure
ci/rehearse/openshift/api/master/e2e-azure 6bf0096 link unknown /pj-rehearse pull-ci-openshift-api-master-e2e-azure
ci/rehearse/openshift/api/release-4.23/e2e-azure 6bf0096 link unknown /pj-rehearse pull-ci-openshift-api-release-4.23-e2e-azure
ci/rehearse/openshift/api/release-5.1/e2e-azure 6bf0096 link unknown /pj-rehearse pull-ci-openshift-api-release-5.1-e2e-azure
ci/rehearse/openshift/installer/main/e2e-azure-ovn-dualstack-ipv6-primary-techpreview 6bf0096 link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv6-primary-techpreview
ci/rehearse/openshift/installer/main/e2e-azure-ovn-dualstack-ipv4-primary-techpreview 6bf0096 link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit b7b2f4e into openshift:main Jul 10, 2026
9 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@sadasu: Jira Issue OCPBUGS-98102: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-98102 has not been moved to the MODIFIED state.

Details

In response to this:

When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step.

Summary by CodeRabbit

Updated OpenShift CI’s Azure IPI step-registry configuration so that DualStack installs use the recommended IPv6 /56 prefix. Specifically, when IP_FAMILY is enabled, the generated install-config.yaml now sets the IPv6 machineNetwork CIDR from fd00::/64 to fd00::/56, affecting the Azure network settings for DualStack cluster provisioning.

Also refreshed the Azure step-registry ownership metadata by updating the OWNERS approvers list and mirroring that change across the related Azure identity/chain/ref and sharednetwork ref/chain metadata.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
…1697)

* OCPBUGS-98102: Update Azure install-config for DualStack

When DualStack is enabled, make the IPv6 machine network's
address prefix to be the recommended /56 in the install-config
customization step.

* Generate step-registry metadata

* Update Azure platform's step-registry owner's list

Keeping this list current.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants