OU-1389: restructure folders#1038
Conversation
|
@PeterYurkovich: This pull request references OU-1389 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThe PR renames the Go proxy package to monitoring and updates server wiring to use the new package. The web app reorganizes imports and module paths across shared, alerts, incidents, legacy dashboards, metrics, perses dashboards, targets, and Cypress code, plus updates package scripts and exposed modules. ChangesBackend package rename
Frontend reorganization
Estimated code review effort: 4 (Complex) | ~60 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
All coderabbit nitpick's are explicitly out of this PR's scope of work as stated in the description |
|
/test? |
|
/test ? |
|
/test e2e-monitoring e2e-coo |
|
@PeterYurkovich: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR looks to update the folder structure of the proposed monitoring-plugin monorepo setup: https://github.com/observability-ui/harness/pull/4/changes
This PR performs as minimal changes as possible to the actual files, and only looks to move the files and create the new folder structure. Further work to do things like split files, refactor to fit the new structure, ect. are left to future PRs.
This PR is independant of #1034 and they can be merged in either order
Summary by CodeRabbit
Bug Fixes
Refactor
Chores / Tests