Skip to content

fix: skip Multisubnet test for single network infra #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhay-nutanix wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: skip Multisubnet test for single network infra #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/e2e/nutanix/multi-subnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,14 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:NutanixMultiSubnets][pl
machineNetworks = infra.Spec.PlatformSpec.Nutanix.FailureDomains
Expect(len(machineNetworks)).ShouldNot(Equal(0))

// The NutanixMultiSubnets feature gate is enabled by the TechPreviewNoUpgrade
// feature set regardless of whether the cluster is actually provisioned with
// multi-subnet infrastructure. When no failure domain defines more than one
// subnet there is nothing to validate, so skip rather than fail.
if !hasMultiSubnetConfiguration(machineNetworks) {
Skip("skipping multi-subnet tests - cluster does not have multi-subnet infrastructure configured")
}

nodes, err = c.CoreV1().Nodes().List(ctx, metav1.ListOptions{})
Expect(err).NotTo(HaveOccurred())
machines, err = mc.Machines("openshift-machine-api").List(ctx, metav1.ListOptions{})
Expand Down