NO-ISSUE: Bump golang.org/x/crypto to v0.52.0#10697
Conversation
This update addresses CVE-2026-39828 (golang.org/x/crypto/ssh unauthorized command execution vulnerability). When an SSH server authentication callback returned PartialSuccessError with non-nil Permissions, those permissions were silently discarded, potentially dropping certificate restrictions such as force-command after a second factor succeeded. This fix changes the behavior so that returning non-nil Permissions with PartialSuccessError now results in a connection error instead of silently discarding the permissions. Updated golang.org/x/crypto from v0.48.0 to v0.52.0 to address this security issue.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
📝 WalkthroughWalkthroughUpdates pinned versions for several ChangesGo module dependency updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@jkaurredhat: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jkaurredhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this PR may be a duplicate because Line 106 in f75ad15 |
|
/hold |
Summary
This PR addresses CVE-2026-39828 by bumping
golang.org/x/cryptofrom v0.48.0 to v0.52.0, which includes a fix for an unauthorized command execution vulnerability in the SSH server implementation.Changes
golang.org/x/cryptofrom v0.48.0 to v0.52.0golang.org/x/net,golang.org/x/sys,golang.org/x/term,golang.org/x/text,golang.org/x/toolsgo mod tidyandgo mod vendor