Skip to content

Platform spec cel unit test#10676

Draft
jcpowermac wants to merge 2 commits into
openshift:mainfrom
jcpowermac:platform-spec-cel-unit-test
Draft

Platform spec cel unit test#10676
jcpowermac wants to merge 2 commits into
openshift:mainfrom
jcpowermac:platform-spec-cel-unit-test

Conversation

@jcpowermac

Copy link
Copy Markdown
Contributor

Adds a generic CRD validation test module (tests/crd/) that verifies
kubebuilder markers are correctly reflected in the generated CRD schema
and behaviorally tests CEL rules via envtest. vSphere is the first
consumer with 35 schema tests and 15 behavioral CEL tests.

Replaces dual Format=ipv4/Format=ipv6 markers on NetworkDeviceSpec
fields (gateway, ipAddrs, nameservers) with CEL XValidation rules,
since only the last Format marker was taking effect.

jcpowermac and others added 2 commits July 8, 2026 13:15
Vendored dependencies for the new tests/crd module which validates
kubebuilder markers in the generated CRD schema.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…th CEL

Adds a generic CRD validation test module (tests/crd/) that verifies
kubebuilder markers are correctly reflected in the generated CRD schema
and behaviorally tests CEL rules via envtest. vSphere is the first
consumer with 35 schema tests and 15 behavioral CEL tests.

Replaces dual Format=ipv4/Format=ipv6 markers on NetworkDeviceSpec
fields (gateway, ipAddrs, nameservers) with CEL XValidation rules,
since only the last Format marker was taking effect.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 08be8da4-14b1-4f1b-9049-577d9ebf1e0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sadasu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac

Copy link
Copy Markdown
Contributor Author

/test unit

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant