HIVE-3175: revendor installer, bump k8s to .36 - #2934
Open
2uasimojo wants to merge 3 commits into
Open
Conversation
|
Important Review skippedToo many files! This PR contains 2817 files, which is 2517 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (183)
📒 Files selected for processing (2817)
You can disable this status message by setting the Use the checkbox below for a quick retry:
|
2uasimojo
changed the title
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-ci-robot
added
the
jira/valid-reference
|
@2uasimojo: This pull request references HIVE-3175 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
Author
|
@coderabbitai Please review the changes under pkg/ |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base_ref="$(git merge-base HEAD origin/main 2>/dev/null || git merge-base HEAD main 2>/dev/null || true)"
if [[ -z "$base_ref" ]]; then
echo "Unable to determine merge base against main."
exit 1
fi
echo "Merge base: $base_ref"
echo
echo "Changed files under pkg/:"
git diff --name-status "$base_ref"...HEAD -- pkg/
echo
echo "Diff statistics under pkg/:"
git diff --stat "$base_ref"...HEAD -- pkg/
echo
echo "Go source outlines under pkg/:"
git diff --name-only --diff-filter=ACMR "$base_ref"...HEAD -- pkg/ \
| grep -E '\.go$' \
| while IFS= read -r file; do
echo "===== $file ====="
ast-grep outline "$file" --items all || true
done
echo
echo "Patch under pkg/:"
git diff --find-renames --find-copies --unified=80 "$base_ref"...HEAD -- pkg/Length of output: 1154 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Available refs:"
git branch -a
git tag --contains HEAD | head -20 || true
echo
echo "Current HEAD:"
git show -s --format='HEAD=%H%nparents=%P%nsubject=%s' HEAD
echo
echo "Repository remotes:"
git remote -v
echo
echo "GitHub PR 2934 metadata:"
gh pr view 2934 --repo openshift/hive --json baseRefName,baseRefOid,headRefName,headRefOid \
--jq '{baseRefName, baseRefOid, headRefName, headRefOid}' || true
echo
echo "Candidate base commits available locally:"
for ref in origin/master master origin/release-4.20 release-4.20; do
if git rev-parse -q --verify "$ref^{commit}" >/dev/null; then
printf '%s: ' "$ref"
git rev-parse "$ref"
fi
doneLength of output: 1635 🏁 Script executed: #!/bin/bash
set -euo pipefail
base="c0b802fe5402c1125e52353b51c1af29f393ffca"
head="3d278c7b77186a50a0b9a4a2645c1a0fbea96d87"
echo "Changed files under pkg/:"
git diff --name-status "$base" "$head" -- pkg/
echo
echo "Patch statistics:"
git diff --stat "$base" "$head" -- pkg/
echo
echo "Changed Go symbols:"
git diff --name-only --diff-filter=ACMR "$base" "$head" -- pkg/ \
| grep -E '\.go$' \
| while IFS= read -r file; do
echo "===== $file ====="
ast-grep outline "$file" --items all || true
done
echo
echo "Patch under pkg/:"
git diff --find-renames --find-copies --unified=100 "$base" "$head" -- pkg/
echo
echo "Tests and direct references to changed package paths:"
git diff --name-only --diff-filter=ACMR "$base" "$head" -- pkg/ \
| sed -n 's#^\(pkg/[^/]*\).*#\1#p' | sort -u \
| while IFS= read -r package_dir; do
echo "===== references for $package_dir ====="
rg -n -C2 --glob '*.go' --glob '*_test.go' \
"$(basename "$package_dir")" . || true
doneLength of output: 201546 🏁 Script executed: #!/bin/bash
set -euo pipefail
base="c0b802fe5402c1125e52353b51c1af29f393ffca"
head="3d278c7b77186a50a0b9a4a2645c1a0fbea96d87"
echo "Changed pkg/ paths, grouped by first component:"
git diff --name-only "$base" "$head" -- pkg/ \
| awk -F/ '{print $1 "/" $2}' | sort | uniq -c | sort -nr
echo
echo "First-party changed files under pkg/ (excluding any vendor path):"
git diff --name-status "$base" "$head" -- pkg/ \
| awk '$2 !~ /\/vendor\// && $NF !~ /\/vendor\// {print}'
echo
echo "First-party Go patch (excluding any vendor path):"
git diff --find-renames --unified=50 "$base" "$head" -- pkg/ \
':(exclude)pkg/**/vendor/**'
echo
echo "Outlines for first-party changed Go files:"
git diff --name-only --diff-filter=ACMR "$base" "$head" -- pkg/ \
| grep -v '/vendor/' \
| grep -E '\.go$' \
| while IFS= read -r file; do
echo "===== $file ====="
ast-grep outline "$file" --items all || true
done
echo
echo "Changed test files under pkg/ (excluding vendor):"
git diff --name-status "$base" "$head" -- pkg/ \
| awk '$2 !~ /\/vendor\// && $NF !~ /\/vendor\// && $NF ~ /_test\.go$/ {print}'Length of output: 67159 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "FakeClientBuilder creation and chained configuration:"
rg -n -U -C2 --glob '*.go' \
'testfake\.NewFakeClientBuilder\(\)(?s:.*?)\.(WithObjects|WithLists|WithRuntimeObjects|WithScheme|WithStatusSubresource|WithIndex)\s*\(' \
--glob '!vendor/**' .
echo
echo "All direct builder method calls in first-party Go code:"
rg -n -C2 --glob '*.go' --glob '!vendor/**' \
'\.(WithObjects|WithLists|WithRuntimeObjects|WithScheme|WithStatusSubresource|WithIndex|WithInterceptorFuncs|WithObjectTracker|WithRESTMapper)\s*\(' .
echo
echo "Subresource calls on clients constructed through the Hive fake builder:"
rg -n -U -C3 --glob '*.go' --glob '!vendor/**' \
'testfake\.NewFakeClientBuilder\(\)(?s:.*?)\.Build\(\)(?s:.*?)\.SubResource\s*\(' .
echo
echo "pkg/test/fake/fake.go with line numbers:"
nl -ba pkg/test/fake/fake.go | sed -n '1,245p'
echo
echo "Baseline FakeClientBuilder API in vendored controller-runtime:"
rg -n -C2 --glob '*.go' \
'func \(.*ClientBuilder\) With(Objects|Lists|RuntimeObjects|InterceptorFuncs|ObjectTracker|RESTMapper|Scheme|StatusSubresource|Index)\s*\(' \
vendor/sigs.k8s.io/controller-runtime/pkg/client/fake || trueLength of output: 208068
I specifically checked the controller-runtime API updates, the new TypeMeta-preserving fake client and its in-repository call sites, and the install-manager REST client migration. I did not run tests because the review sandbox does not execute repository code. |
Member
Author
|
/assign @suhanime |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
==========================================
+ Coverage 50.51% 50.53% +0.01%
==========================================
Files 282 282
Lines 34485 34581 +96
==========================================
+ Hits 17420 17475 +55
- Misses 15707 15748 +41
Partials 1358 1358
🚀 New features to boost your workflow:
|
Contributor
|
@2uasimojo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: claude