[release-ocm-2.15] MGMT-24352: Reset finalizing timeout on transition from installing-pending-user-action - #10752
Conversation
…ction When a non-essential worker gets stuck in installing-pending-user-action the rest of the cluster can still progress to finalizing. The cluster-level Done finalization timeout (70 min) can then expire before the per-host timeout chain completes (40 min Rebooting + 60 min pending-user-action = 100 min). In this situation, when the stuck host moves from `installing-pending-user-action` to either `error` or `installing-in-progress` the entire cluster will fail instead of evicting the stuck host and completing with the remaining nodes. This commit changesthe cluster state transition so it will reset progress_finalizing_stage_started_at and progress_finalizing_stage_timed_out when transitioning FROM InstallingPendingUserAction TO Finalizing. This gives the cluster a fresh 70-minute timeout window, allowing sufficient time for the host to either finish installation (if the boot issue was fixed) or error (in which case the cluster will succeed without it). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Resolves https://redhat.atlassian.net/browse/MGMT-24352
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-24352 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
openshift-ci
Bot
added
the
size/L
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.15 #10752 +/- ##
=================================================
Coverage 43.65% 43.65%
=================================================
Files 408 408
Lines 70647 70651 +4
=================================================
+ Hits 30839 30842 +3
- Misses 37028 37029 +1
Partials 2780 2780
🚀 New features to boost your workflow:
|
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-reference
|
@pastequo: This pull request references MGMT-24352 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, pastequo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
549b36a
into
openshift:release-ocm-2.15
4 participants
This is an automated cherry-pick of #10293
/assign pastequo