Skip to content

[release-1.37] update metadata to 1.37.2 release#4140

Open
maschmid wants to merge 11 commits into
openshift-knative:release-1.37from
maschmid:maschmid-towards-1.37.2
Open

[release-1.37] update metadata to 1.37.2 release#4140
maschmid wants to merge 11 commits into
openshift-knative:release-1.37from
maschmid:maschmid-towards-1.37.2

Conversation

@maschmid

@maschmid maschmid commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot requested review from Kaustubh-pande and aliok July 9, 2026 06:49
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 9, 2026
@maschmid

maschmid commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

that generated files failure shows diff

RUN /bin/opm render --skip-tls-verify -o yaml \
-       >> /configs/index.yaml
+      registry.ci.openshift.org/knative/serverless-bundle@sha256:515e93d4eb2309322b2bcf6d0035f53ea982097649a49ad63b275cecd9ac4c06 >> /configs/index.yaml

IMHO is wrong, that bundle contains a 1.38 build. I don't remember how do we normally handle this chicken/egg issue of updating version but not having a bundle with the correct version at the same time? (do we just force merge this one and then do another PR with make generated-files that will use a proper CI bundle ?

@maschmid

maschmid commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/test 421-images

@maschmid

Copy link
Copy Markdown
Contributor Author

/test 421-images

@maschmid

Copy link
Copy Markdown
Contributor Author

/retest

@maschmid

maschmid commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

that generated files failure shows diff

RUN /bin/opm render --skip-tls-verify -o yaml \
-       >> /configs/index.yaml
+      registry.ci.openshift.org/knative/serverless-bundle@sha256:515e93d4eb2309322b2bcf6d0035f53ea982097649a49ad63b275cecd9ac4c06 >> /configs/index.yaml

IMHO is wrong, that bundle contains a 1.38 build. I don't remember how do we normally handle this chicken/egg issue of updating version but not having a bundle with the correct version at the same time? (do we just force merge this one and then do another PR with make generated-files that will use a proper CI bundle ?

Trying to fix that by not having the bundle there at all, and only adding the on-cluster-built bundle here: https://github.com/openshift-knative/serverless-operator/pull/4140/changes#diff-d6ee23a8f1c82d66144020b6ba63537a521631d860104bf14f1a2a6e717eb1d3R79

AFAIK, the index image as built in prow is not used anywhere, so it should not matter that that index image will not have the current bundle there at all. (but let's see)

(catalogsource.bash has two paths: one that uses the on-cluster build of index, and the other that uses the konflux index.. we should probabl just not build the index in prow at all)

(we can put it back once we have a bundle for 1.37.2 built in konflux)

@maschmid

Copy link
Copy Markdown
Contributor Author

/test 421-test-upgrade

@maschmid

Copy link
Copy Markdown
Contributor Author

/test 420-kitchensink-upgrade

1 similar comment
@maschmid

Copy link
Copy Markdown
Contributor Author

/test 420-kitchensink-upgrade

@maschmid

Copy link
Copy Markdown
Contributor Author

Opening #4142 to fix that flaky " eventtransform.go:75: failed to create resource the server could not find the requested resource" kitchensink-upgrade problem in main first.

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@maschmid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/420-kitchensink-upgrade aff0908 link false /test 420-kitchensink-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant