Skip to content

mls (v5.11) - #4916

Open
Aotumuri wants to merge 2 commits into
openfrontio:mainfrom
Aotumuri:mls-5-11
Open

mls (v5.11)#4916
Aotumuri wants to merge 2 commits into
openfrontio:mainfrom
Aotumuri:mls-5-11

Conversation

@Aotumuri

@Aotumuri Aotumuri commented Aug 9, 2026

Copy link
Copy Markdown
Member

Description:

Version identifier within MLS: v5.11

[Changed languages]

  • bg
  • fr
  • hu
  • ja
  • pt-BR
  • ru
  • uk

[Change volume]

  • Changed languages: 7
  • Changed files: 7
  • Changed lines: 13334
  • metadata.json: unchanged

Final reviewer: meow

This PR was generated by the PR sender tool, then checked and submitted by the final reviewer.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This pull request synchronizes seven locale catalogs with current UI keys. It adds and revises translations for account, graphics, matchmaking, statistics, maps, store, Steam, streaming, tribes, and username validation features.

Changes

Localization catalog refresh

Layer / File(s) Summary
Account and common UI translations
resources/lang/bg.json, resources/lang/fr.json, resources/lang/hu.json, resources/lang/ja.json, resources/lang/pt-BR.json, resources/lang/ru.json, resources/lang/uk.json
Updates account, clan, common, cosmetics, effects, and streaming translations. Removes obsolete keys and reorders shared labels.
Graphics, maps, and matchmaking translations
resources/lang/bg.json, resources/lang/hu.json, resources/lang/ja.json, resources/lang/uk.json
Adds graphics presets, JSON import/export text, map layers, map names, matchmaking validation, lobby controls, and gameplay labels.
Statistics and leaderboard translations
resources/lang/bg.json, resources/lang/fr.json, resources/lang/hu.json, resources/lang/ja.json, resources/lang/pt-BR.json, resources/lang/ru.json, resources/lang/uk.json
Adds leaderboard columns, ranked and tribe metrics, game statistics, player statistics, and profile messages.
Store, Steam, and validation translations
resources/lang/bg.json, resources/lang/fr.json, resources/lang/hu.json, resources/lang/ja.json, resources/lang/pt-BR.json, resources/lang/ru.json, resources/lang/uk.json
Adds store, merchandise, tribe, Steam, wishlist, username-validation, streaming, and match-result translations. Relocates several Steam and common entries.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: Translation

Suggested reviewers: evanpelle

Poem

Seven catalogs align,
New UI keys now read and shine.
Maps and graphics gain their names,
Stores and streams join updated frames.
Old keys leave, new terms stay—
Locale text moves with the UI today.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description identifies the MLS version and lists the seven localization files changed.
Title check ✅ Passed The title clearly identifies the MLS version update covered by the localization changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/lang/bg.json`:
- Line 1737: Correct the misspelled Bulgarian word in the account_invalid_chars
translation, replacing “резстояния” with “разстояния” while preserving the rest
of the validation message.

In `@resources/lang/hu.json`:
- Line 84: Update the username_grace_warning translation to use the shared
{date} placeholder instead of the localized {dátum} token, preserving the rest
of the Hungarian message unchanged.

In `@resources/lang/ja.json`:
- Line 1020: Update the clearwaterlakes translation value in ja.json to a
recognizable Japanese name for Clearwater Lakes, such as クリアウォーター湖群, while
preserving the existing translation key and JSON structure.
- Line 286: Update the member_count translation in ja.json so its plural output
describes the number of clan members rather than team matches, while preserving
the existing count placeholder and ICU plural structure.

In `@resources/lang/pt-BR.json`:
- Line 425: Update the signup_bonus translation value to Brazilian Portuguese,
replacing the European Portuguese wording with “Bônus de cadastro” while keeping
the existing translation key unchanged.

In `@resources/lang/ru.json`:
- Line 1500: Update resources/lang/ru.json:1500-1500 and
resources/lang/uk.json:1500-1500 so tribe_boost_count_plural uses ICU one, few,
and many plural categories, with the appropriate Russian подъём and Ukrainian
підйом forms instead of a single plural string.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f3405e0-c9b1-4dba-8954-9ff2942f2f5a

📥 Commits

Reviewing files that changed from the base of the PR and between 332e541 and b7efc1b.

📒 Files selected for processing (7)
  • resources/lang/bg.json
  • resources/lang/fr.json
  • resources/lang/hu.json
  • resources/lang/ja.json
  • resources/lang/pt-BR.json
  • resources/lang/ru.json
  • resources/lang/uk.json

Comment thread resources/lang/bg.json
Comment thread resources/lang/hu.json Outdated
Comment thread resources/lang/ja.json
Comment thread resources/lang/ja.json
Comment thread resources/lang/pt-BR.json
Comment thread resources/lang/ru.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Aug 9, 2026
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/lang/hu.json`:
- Line 84: Update the Hungarian username_grace_warning translation to use the
informal register by replacing “elveszíti” with “elveszíted” and “Iratkozzon
fel” with “Iratkozz fel”, while preserving the placeholders and remaining
message text.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 423d94c0-f5ee-4ca2-b93d-1e8e5ba496a6

📥 Commits

Reviewing files that changed from the base of the PR and between b7efc1b and 08167d6.

📒 Files selected for processing (1)
  • resources/lang/hu.json

Comment thread resources/lang/hu.json
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Final Review

Development

Successfully merging this pull request may close these issues.

3 participants