Skip to content

ofDirectory::listDir performance improvement - #7399

Closed
dimitre wants to merge 7 commits into
openframeworks:masterfrom
dimitre:dir
Closed

ofDirectory::listDir performance improvement#7399
dimitre wants to merge 7 commits into
openframeworks:masterfrom
dimitre:dir

Conversation

@dimitre

@dimitre dimitre commented Mar 17, 2023

Copy link
Copy Markdown
Member

still a draft. other things to do

  • test devices
  • implement hidden files

as it breaks api, better to implement in a major version change. 0.12.0 ?

closes #6129

@dimitre dimitre added this to the 0.12.0 milestone Mar 17, 2023
@ofTheo ofTheo self-assigned this Apr 7, 2023
@ofTheo

ofTheo commented Apr 7, 2023

Copy link
Copy Markdown
Member

Adding this issue for reference: #6129

@ofTheo

ofTheo commented Apr 19, 2023

Copy link
Copy Markdown
Member

@dimitre going to do a PR just for the sorting speed for #6129

ListDir is still quite slow and I think a PR which doesn't break the api would be good.
I'll add some thoughts to this PR in comments on how we could do that.

EDIT: a big issue is that ofDirectory::files is public, so there isn't really a way to change the type to of::filesystem::path without breaking things for people.

I think maybe let's close this PR for now and revisit after 0.12.0.

@dimitre

dimitre commented Apr 19, 2023

Copy link
Copy Markdown
Member Author

Nice. I think it is possible to update ofDirectory not to open file immediatly. this would speed up everything.

@ofTheo

ofTheo commented Apr 19, 2023

Copy link
Copy Markdown
Member

sounds good @dimitre! - PR #7509 speeds up sort by quite a bit ( even more for larger directories ) and doesn't change current behavior.

@dimitre dimitre modified the milestones: 0.12.0, 0.13.0 Apr 20, 2023
@dimitre dimitre closed this Nov 12, 2025
@dimitre
dimitre deleted the dir branch November 12, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ofDirectory::sort() is slow!

2 participants