Fix dangling read buffer in PNG memory decoding#2084
Open
Tutez64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the lifetime of the
ReadBufferpassed to libpng when decoding PNG data from memory.PNG::Decodepreviously created the buffer inside anif/elseblock and passed its address topng_set_read_fn. The buffer went out of scope beforepng_read_infoinvoked the callback, leaving libpng with a dangling pointer.The issue was visible when Lime was built with LTO, causing intermittent
libpng error: Read Errormessages, corrupted or missing images, and occasional crashes.This change keeps the buffer alive for the entire
PNG::Decodecall. It also makesReadBuffer::Readreject reads that exceed the remaining data instead of performing a partial copy.Repro
LimePNGReadBufferLTORepro.zip