feat: add clickhouse-backup based backup/restore support#22
Open
shivansh-source wants to merge 1 commit into
Open
feat: add clickhouse-backup based backup/restore support#22shivansh-source wants to merge 1 commit into
shivansh-source wants to merge 1 commit into
Conversation
Signed-off-by: shivansh-source <shivansh-source@users.noreply.github.com>
Author
|
/cc @spron-in |
Collaborator
|
Thanks @shivansh-source . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
Implements backup/restore via clickhouse-backup, run as a sidecar and driven through the ProviderManaged BackupProvider interface (SyncBackup/SyncRestore/CleanupBackup/CleanupRestore) already built into provider-runtime.
v1 scope: one backup storage only (clickhouse-backup's REST API only supports one static destination, fixed at sidecar startup), no PITR, no scheduled backups, and backups must be set at instance creation since the sidecar only gets wired into the CHI pod template once.
BackupClass CR isn't shipped by the chart yet — README has the YAML to apply by hand for now, keeping this PR to the provider-side plumbing.
Verified go build/vet/test (16 new tests) and helm lint pass.