rewrite dac consumer module - #3878
Draft
benderl wants to merge 1 commit into
Draft
Conversation
benderl
force-pushed
the
fixes-dac-comsumer
branch
2 times, most recently
from
August 31, 2026 11:05
c8754c5 to
deaa366
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks generic DAC consumers to support model-driven scaling, live-zero signals, and both M120T outputs.
Changes:
- Centralizes DAC model parameters.
- Adds configurable signal-range mapping.
- Adds separate M120T output selections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
model.py |
Defines model-specific output parameters. |
consumer.py |
Implements generic scaling and Modbus writes. |
config.py |
Adds signal-range configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benderl
force-pushed
the
fixes-dac-comsumer
branch
from
August 31, 2026 11:11
deaa366 to
134ad5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: openWB/openwb-ui-settings#1070