feat: add Parquet output format for layerstats#1546
Open
1Ninad wants to merge 7 commits into
Open
Conversation
Full logs: https://github.com/onthegomap/planetiler/actions/runs/24568351799 |
Contributor
Author
|
Hi @msbarry, could you please review the PR when you have time? Thanks. |
Contributor
|
I think we should just replace TSV with Parquet, not sure how many people are actually using layerstats as-is. |
Contributor
Author
|
Sure, I can remove the existing TSV output. Let me know if anything else needs changes. |
msbarry
reviewed
Apr 15, 2026
| org.apache.hadoop.fs.Path hadoopPath = new org.apache.hadoop.fs.Path(output.toString()); | ||
| this.writer = ExampleParquetWriter.builder(hadoopPath) | ||
| .withType(SCHEMA) | ||
| .withCompressionCodec(CompressionCodecName.SNAPPY) |
Contributor
There was a problem hiding this comment.
@bdon any preference on encoding/row group size here? What do you usually use when converting?
msbarry
reviewed
Apr 15, 2026
Contributor
|
Thanks for adding this! I'm OK removing TSV option, let's just compare how long it takes to write the parquet output over a larger area to make sure it's not much worse than TSV was. We can compare against main branch as well so don't need to block removing tsv from this PR. |
Contributor
Author
Got it, I’ll remove the TSV in this PR. |
Contributor
Author
|
Done. Please review |
msbarry
reviewed
Apr 17, 2026
…/PlanetilerConfig.java Co-authored-by: Michael Barry <msbarry@users.noreply.github.com>
msbarry
reviewed
Apr 17, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1045
This PR adds a
--layerstats-format=parquetflag so users can write layerstats as Parquet instead. Parquet is more compact. TSV remains the default, so nothing breaks for existing users.