Skip to content

[Testing] Add lifecycle regression tests for grpcserver and optimistic sync pipeline - #8636

Open
janezpodhostnik wants to merge 1 commit into
janez/flaky-test-regression-coverage-networkfrom
janez/flaky-test-regression-coverage-lifecycle
Open

[Testing] Add lifecycle regression tests for grpcserver and optimistic sync pipeline#8636
janezpodhostnik wants to merge 1 commit into
janez/flaky-test-regression-coverage-networkfrom
janez/flaky-test-regression-coverage-lifecycle

Conversation

@janezpodhostnik

@janezpodhostnik janezpodhostnik commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Adds regression coverage for the two component-lifecycle fixes from #8633. Each new test was verified to fail with the corresponding fix reverted, and to pass with it.

Changes

  • module/grpcserver: first tests for the package. Verify a normal start/stop lifecycle throws nothing, that an immediate shutdown racing startup does not throw ErrServerStopped (50 iterations amplify the race between the shutdown worker's GracefulStop and the serve worker reaching Serve), and that a genuine listen failure is still thrown as irrecoverable.
  • optimistic sync pipeline: verify a parent state update delivered before Run is not lost when Run is invoked with a stale initial parent state. Before the fix, the pipeline deadlocked in StateWaitingPersist and never persisted; the test drives it to StateComplete.

Related: #8633


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@janezpodhostnik
janezpodhostnik requested a review from a team as a code owner August 3, 2026 14:20
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3592d9b2-522b-4e85-9ba9-83acb7e459b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janezpodhostnik janezpodhostnik self-assigned this Aug 4, 2026
@janezpodhostnik janezpodhostnik changed the title Add lifecycle regression tests for grpcserver and optimistic sync pipeline [Testing] Add lifecycle regression tests for grpcserver and optimistic sync pipeline Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant