Skip to content

Prepend anchors 0.6 - #205

Open
jo-mueller wants to merge 2 commits into
ome:mainfrom
jo-mueller:prepend-anchors-0.6
Open

Prepend anchors 0.6#205
jo-mueller wants to merge 2 commits into
ome:mainfrom
jo-mueller:prepend-anchors-0.6

Conversation

@jo-mueller

@jo-mueller jo-mueller commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The anchors that are autogenerated in the pre_build.py script (i.e., here on main) are generated in exactly the same way on all the other branches of ngff-spec, which leads to confusion with how anchors are resolved over at ngff (see also ome/ngff#607)

This solves it on main, but the fix will have to be ported over to the 0.1 ... 0.5 branches, too.

Another small issue I noted - the examples section lists its own index.md as part of the examples:

image

Which is fixed in ee4b168 here, too. Big screenshot for a small fix.

@github-actions

Copy link
Copy Markdown

Automated Review URLs

@jo-mueller

Copy link
Copy Markdown
Contributor Author

@lubianat @clbarnes I think this would actually be important to get in before tagging 0.6 as part of the fix for ome/ngff#607. After 0.6 is tagged, we cannot change it because we cannot edit the tag.

We could (and probably should) archive 0.6 on a different branch though, so we can make these small build fixes for 0.6 in the future, too.

@clbarnes

Copy link
Copy Markdown
Contributor

One thing to consider about the anchors is that the colons get normalised to hyphens in the built site, so maybe it's best to write them as hyphens in the first place to minimise confusion/ in case someone tries to differentiate two anchors by colon/hyphen?

@lubianat

Copy link
Copy Markdown
Contributor

I approved it in all to allow merge and leave @jo-mueller to decide what to do with @clbarnes's comment (which makes sense)

I think though we should stop supporting changes on 0.1, 0.2 and 0.3 (unless they are security vulnerabilities)....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants