test: reason strings for bare #[ignore] in matching and rsync_io - #7049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convert the six bare
#[ignore]attributes in thematchingandrsync_iotest crates to#[ignore = "<reason>"], lifting the reason from each test's existing adjacent doc comment.Bare
#[ignore]prints nothing about why a test is skipped; the= "reason"form surfaces it directly incargo nextest/cargo testoutput, so a reader of a skipped-test line knows whether it is a resource-heavy opt-in or a genuine gap.Scope
crates/matching/tests/sparse_match_fixture.rs(2) - 16 MB rolling-hash stress casescrates/matching/src/index/sparse_match_tests.rs(1) - 100 MiB allocation stress casecrates/rsync_io/tests/concurrent_session_validation.rs(3) - 256/512 concurrent-session fd pressure and a timing-based assertionNo test bodies changed, nothing un-ignored, no already-reasoned attribute touched.
Verification
cargo fmt --all -- --check: cleancargo clippy -p matching -p rsync_io --all-targets --all-features --no-deps -- -D warnings: cleancargo nextest run -p matching -p rsync_io --all-features: 1484 passed, 6 skipped (the reasoned stress/timing cases, correctly not run)