Skip to content

fix(webhooks): forward overrides from webhooks.list #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toolshedlabs-hash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(webhooks): forward overrides from webhooks.list #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
nylas-python Changelog
======================
Unreleased
----------
* Fixed `webhooks.list()` dropping the `overrides` argument, so per request `api_key`, `api_uri`, `timeout` and `headers` now apply to it

v6.17.0
----------
* Clarify that event `default` visibility is Google-only
Expand Down
6 changes: 5 additions & 1 deletion nylas/resources/webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ def list(self, overrides: RequestOverrides = None) -> ListResponse[Webhook]:
Returns:
The list of webhook destinations
"""
return super().list(path="/v3/webhooks", response_type=Webhook)
return super().list(
path="/v3/webhooks",
response_type=Webhook,
overrides=overrides,
)

def find(
self, webhook_id: str, overrides: RequestOverrides = None
Expand Down
10 changes: 10 additions & 0 deletions tests/resources/test_webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,16 @@ def test_list_webhooks(self, http_client_list_response):
"GET", "/v3/webhooks", None, None, None, overrides=None
)

def test_list_webhooks_with_overrides(self, http_client_list_response):
webhooks = Webhooks(http_client_list_response)
overrides = {"api_key": "override-key", "api_uri": "https://override.nylas.com"}

webhooks.list(overrides=overrides)

http_client_list_response._execute.assert_called_once_with(
"GET", "/v3/webhooks", None, None, None, overrides=overrides
)

def test_find_webhook(self, http_client_response):
webhooks = Webhooks(http_client_response)

Expand Down