Skip to content

feat(button): add support for 2xs and 3xs to button#6666

Open
Barbapapazes wants to merge 1 commit into
nuxt:v4from
Barbapapazes:feat/2xs-3xs-button
Open

feat(button): add support for 2xs and 3xs to button#6666
Barbapapazes wants to merge 1 commit into
nuxt:v4from
Barbapapazes:feat/2xs-3xs-button

Conversation

@Barbapapazes

@Barbapapazes Barbapapazes commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

fix #6581

@github-actions github-actions Bot added the v4 #4488 label Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70d24750-12f8-414e-9c53-6b4f25167cd3

📥 Commits

Reviewing files that changed from the base of the PR and between 08bdab4 and 28eb3a4.

⛔ Files ignored due to path filters (4)
  • test/components/__snapshots__/Button-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Button.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/FieldGroup-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/FieldGroup.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • docs/content.config.ts
  • src/theme/button.ts

📝 Walkthrough

Walkthrough

This change extends the Button component's size options by adding two new smaller variants, 3xs and 2xs. The Zod schema in the docs config is updated to allow these new enum values, and the theme configuration adds corresponding base classes, icon/avatar sizing classes, and square button compound variant padding for the new sizes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Changes

Cohort / File(s) Summary
Button size variant expansion
docs/content.config.ts, src/theme/button.ts
Adds 3xs and 2xs to the Button size enum and defines corresponding theme classes and compound variants

Sequence Diagram(s)

Not applicable — this change consists of static schema and style configuration additions without observable runtime interaction flows.

Related issues: None specified.

Related PRs: None specified.

Suggested labels: enhancement, theme

Suggested reviewers: benjamincanac

🐰

A hop, a size, a tiny new class,
3xs and 2xs now fit in the mass,
Padding so snug on squares small and neat,
The button grows shorter, still nimble and sweet. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description only references an issue number and does not describe the code changes. Add a brief summary of the button size and styling updates so the description reflects the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding 2xs and 3xs button sizes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button with size=xxs

1 participant