fix: revert empty-frame workaround (#83)#84
Draft
benjamincanac wants to merge 2 commits into
Draft
Conversation
#83 misdiagnosed the empty "Thinking…" frame during streaming as the createUIMessageStream wrapper's fault and switched to direct toUIMessageStream, which broke assistant persistence (responseMessage.id was empty). The real cause is a stale showIndicator computed in @nuxt/ui UChatMessages, fixed upstream in nuxt/ui#6673. Restores the wrapper (real message id, in-stream data-chat-title) and points @nuxt/ui at the #6673 pkg.pr.new build to verify.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The restored pre-#83 route imported @ai-sdk/gateway, which isn't a dependency (Rollup failed to resolve it). Bare provider/model strings resolve via ai's default gateway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #83 ("avoid empty assistant frame during streaming").
Why: #83 was a misdiagnosis. The empty "Thinking…" frame that stays for the whole stream is a stale
showIndicatorcomputed in@nuxt/ui'sUChatMessages— it readslastMessage.parts.length, but@ai-sdk/vuemutates messages in place undershallowRef+triggerRef, so it only re-runs onstatuschange. Fixed upstream in nuxt/ui#6673.#83 dropped the
createUIMessageStreamwrapper for directtoUIMessageStream, which broke assistant-message persistence (responseMessage.idwas""→onConflictDoNothingskipped every insert).This PR restores the wrapper (real message id, in-stream
data-chat-titletitle) and points@nuxt/uiat the nuxt/ui#6673 preview build (pkg.pr.new) to verify the indicator fix.Draft until nuxt/ui#6673 is released — then bump
@nuxt/uiback to a published version.