fix(db): make PostgreSQL migrations atomic - #921
Open
onmax wants to merge 1 commit into
Open
Conversation
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL migrations are currently executed one statement at a time, with
_hub_migrationsupdated only after every statement succeeds. A later failure can therefore leave committed DDL without a tracker row, while overlapping runners can both decide that the same migration is pending.Fix
For PostgreSQL only, this PR:
_hub_migrationsafter acquiring the lock;DOstatement, so both succeed or both roll back.Other dialects keep their existing behavior. Using one server-side statement also avoids requiring interactive transaction support from the driver.
Compatibility
This requires PL/pgSQL, which PostgreSQL installs by default. Commands PostgreSQL forbids inside transactions, such as
CREATE INDEX CONCURRENTLY, fail without applying or recording the migration. Neon HTTP was not tested against a live endpoint; Drizzle forwards the wrapper throughdb.execute()as one query.