fix: guard optional onExit cleanup handler - #237
Open
pupuking723 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
signal-exitcan returnundefinedfromonExit()in some versions/environments.write-file-atomiccurrently assumes the return value is always a remover function, so the async and sync paths can throw while leaving thefinallycleanup section even when the write itself succeeded.This adds a no-op fallback for the optional remover and covers both async and sync writes with a regression test that mocks
onExit()to returnundefined.Verification:
npx tap --no-coverage test/basic.jsnpm run eslint -- lib/index.js test/basic.jsgit diff --checknpm testpasses tests, coverage, and eslint locally, then fails only intemplate-oss-checkbecause the generated repository template wants unrelated.githubbranch/template updates. I did not include those unrelated tooling changes in this bugfix PR.