Skip to content

fix: same-origin/origin-when-cross-origin referrer compares wrong origins #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: same-origin/origin-when-cross-origin referrer compares wrong origins #5487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web/fetch/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,15 +481,15 @@ function determineRequestsReferrer (request) {
case 'same-origin':
// 1. If the origin of referrerURL and the origin of request’s current
// URL are the same, then return referrerURL.
if (sameOrigin(request, referrerURL)) {
if (sameOrigin(referrerURL, requestCurrentURL(request))) {
return referrerURL
}
// 2. Return no referrer.
return 'no-referrer'
case 'origin-when-cross-origin':
// 1. If the origin of referrerURL and the origin of request’s current
// URL are the same, then return referrerURL.
if (sameOrigin(request, referrerURL)) {
if (sameOrigin(referrerURL, requestCurrentURL(request))) {
return referrerURL
}
// 2. Return referrerOrigin.
Expand Down
47 changes: 47 additions & 0 deletions test/fetch/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,50 @@ describe('isOriginIPPotentiallyTrustworthy()', () => {
})
})
})

describe('determineRequestsReferrer', () => {
const referrer = new URL('https://example.com/page?secret=1#frag')
const sameOriginURL = new URL('https://example.com/target')
const crossOriginURL = new URL('https://other.example/target')

function makeRequest (referrerPolicy, currentURL) {
return {
referrerPolicy,
referrer,
urlList: [currentURL],
origin: currentURL.origin
}
}

test('same-origin returns the referrer URL for a same-origin request', (t) => {
t.plan(1)

const result = util.determineRequestsReferrer(makeRequest('same-origin', sameOriginURL))

t.assert.strictEqual(result.toString(), 'https://example.com/page?secret=1')
})

test('same-origin returns no referrer for a cross-origin request', (t) => {
t.plan(1)

const result = util.determineRequestsReferrer(makeRequest('same-origin', crossOriginURL))

t.assert.strictEqual(result, 'no-referrer')
})

test('origin-when-cross-origin returns the referrer URL for a same-origin request', (t) => {
t.plan(1)

const result = util.determineRequestsReferrer(makeRequest('origin-when-cross-origin', sameOriginURL))

t.assert.strictEqual(result.toString(), 'https://example.com/page?secret=1')
})

test('origin-when-cross-origin returns the referrer origin for a cross-origin request', (t) => {
t.plan(1)

const result = util.determineRequestsReferrer(makeRequest('origin-when-cross-origin', crossOriginURL))

t.assert.strictEqual(result.toString(), 'https://example.com/')
})
})