Skip to content

fix(types): add optional logs parameter to filterCallsByX functions #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukejane wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Open

fix(types): add optional logs parameter to filterCallsByX functions #5399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b326914
fix(types): add optional logs parameter to filterCallsByX functions
mukejane Jun 8, 2026
a7774d0
fix(eventsource): set credentials to 'include' when withCredentials i…
mukejane Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web/eventsource/eventsource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class EventSource extends EventTarget {
mode: 'cors',
credentials: corsAttributeState === 'anonymous'
? 'same-origin'
: 'omit',
: 'include',

@mcollina mcollina Jun 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

referrer: 'no-referrer'
}

Expand Down
16 changes: 8 additions & 8 deletions types/mock-call-history.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,21 +87,21 @@ declare class MockCallHistory {
/** return all MockCallHistoryLog matching any of criteria given. if an object is used with multiple properties, you can change the operator to apply during filtering on options */
filterCalls (criteria: MockCallHistory.FilterCallsFunctionCriteria | MockCallHistory.FilterCallsObjectCriteria | RegExp, options?: MockCallHistory.FilterCallsOptions): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given protocol. if a string is given, it is matched with includes */
filterCallsByProtocol (protocol: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByProtocol (protocol: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given host. if a string is given, it is matched with includes */
filterCallsByHost (host: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByHost (host: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given port. if a string is given, it is matched with includes */
filterCallsByPort (port: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByPort (port: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given origin. if a string is given, it is matched with includes */
filterCallsByOrigin (origin: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByOrigin (origin: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given path. if a string is given, it is matched with includes */
filterCallsByPath (path: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByPath (path: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given hash. if a string is given, it is matched with includes */
filterCallsByHash (hash: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByHash (hash: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given fullUrl. if a string is given, it is matched with includes */
filterCallsByFullUrl (fullUrl: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByFullUrl (fullUrl: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>
/** return all MockCallHistoryLog matching the given method. if a string is given, it is matched with includes */
filterCallsByMethod (method: MockCallHistory.FilterCallsParameter): Array<MockCallHistoryLog>
filterCallsByMethod (method: MockCallHistory.FilterCallsParameter, logs?: Array<MockCallHistoryLog>): Array<MockCallHistoryLog>

@mcollina mcollina Jun 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those needs matching type tests changes

/** clear all MockCallHistoryLog on this MockCallHistory. */
clear (): void
/** use it with for..of loop or spread operator */
Expand Down