Skip to content

tools: add workflow to compare Nix changes#64410

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:nix-auto-review-derivation-diff
Open

tools: add workflow to compare Nix changes#64410
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:nix-auto-review-derivation-diff

Conversation

@aduh95

@aduh95 aduh95 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

If a change breaks e.g. the benchmark workflow, it might be not obvious to detect as we typically do not run any benchmark when bumping the nixpkgs pin.
The added workflows will verify that all derivations can be built on all platforms, and report the list of changes by commenting on the PR.

I'm also moving the lint-nix job, so it no longer runs on PRs that do not touch Nix changes.

I've tested this with aduh95#44

If a change breaks e.g. the benchmark workflow, it might be not obvious
to detect as we typically do not run any benchmark when bumping the
nixpkgs pin.
The added workflows will verify that all derivations can be built on all
platforms, and report the list of changes.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 10, 2026
@aduh95 aduh95 requested a review from panva July 10, 2026 15:00
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 10, 2026
aduh95 added 2 commits July 11, 2026 12:11
Do not attempt to add comment on non-PR runs, i.e. when pushing to
`main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants