Skip to content

doc: add note on visibility of CI failures to new contributor guide #64256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sxa wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Open

doc: add note on visibility of CI failures to new contributor guide #64256

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c461578
doc: add note on visibility of CI failures to new contributor guide
sxa Jul 2, 2026
649c1be
fixups following review
sxa Jul 3, 2026
b0de4e9
Update doc/contributing/first-contributions.md
sxa Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/contributing/first-contributions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,13 @@ before approving the CI runs. Similar to the review process, be patient and resp
the volunteers' time when you are asking for help to trigger the CI runs, this helps build
trust to make future contributions smoother.

Since read access to the Jenkins CI is also restricted, one of the collaborators also will need to
let you know about any failures unless you are a member of one of the platform teams in the Node.js
organisation. If after a day or so from a collaborator triggering a Jenkins CI your PR shows a
Comment thread
sxa marked this conversation as resolved.
Outdated
failure in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a
comment to the PR asking what tests are failed, as the collaborator may not realise that you cannot
see the results directly.

### Q: The CI runs showed some failures that seem unrelated to my change. What should I do?

The Node.js CIs are known to be flaky. Consult the daily reports in
Expand Down
Loading