Skip to content

chore: remove vitest deps #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengmk2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: remove vitest deps #832

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f592dd
chore: remove vitest deps
fengmk2 Jun 19, 2026
08989a0
Update
fengmk2 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@
"tshy-after": "^1.4.1",
"typescript": "^6.0.0",
"vite": "npm:@voidzero-dev/vite-plus-core@0.2.1",
"vite-plus": "0.2.1",
"vitest": "4.1.9"
"vite-plus": "0.2.1"

@gemini-code-assist gemini-code-assist Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package @vitest/coverage-v8 (on line 92 of package.json) has a peer dependency on vitest. Removing vitest from devDependencies while keeping @vitest/coverage-v8 will result in an unmet peer dependency warning/error during installation (especially with pnpm).

If the goal of this PR is to completely remove Vitest-related direct dependencies, please also remove @vitest/coverage-v8 from devDependencies on line 92:

-    "@vitest/coverage-v8": "4.1.9",

Otherwise, if coverage is still required, vitest should be kept in devDependencies.

},
"tshy": {
"exports": {
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading