Handle malformed LZF back references - #84
Closed
yawkat wants to merge 1 commit into
Closed
Conversation
Ensure LZF decoders report LZFException when malformed chunks end before back-reference metadata, and add regression coverage for safe and optimal decoder paths. Co-Authored-By: multicode <multicode@yawk.at>
yawkat
commented
Jul 23, 2026
Comment on lines
59
to
+66
| if (ctrl < LZFChunk.MAX_LITERAL) { // literal run | ||
| switch (ctrl) { | ||
| case 31: | ||
| out[outPos++] = in[inPos++]; | ||
| case 30: | ||
| out[outPos++] = in[inPos++]; | ||
| case 29: | ||
| out[outPos++] = in[inPos++]; | ||
| case 28: | ||
| out[outPos++] = in[inPos++]; | ||
| case 27: | ||
| out[outPos++] = in[inPos++]; | ||
| case 26: | ||
| out[outPos++] = in[inPos++]; | ||
| case 25: | ||
| out[outPos++] = in[inPos++]; | ||
| case 24: | ||
| out[outPos++] = in[inPos++]; | ||
| case 23: | ||
| out[outPos++] = in[inPos++]; | ||
| case 22: | ||
| out[outPos++] = in[inPos++]; | ||
| case 21: | ||
| out[outPos++] = in[inPos++]; | ||
| case 20: | ||
| out[outPos++] = in[inPos++]; | ||
| case 19: | ||
| out[outPos++] = in[inPos++]; | ||
| case 18: | ||
| out[outPos++] = in[inPos++]; | ||
| case 17: | ||
| out[outPos++] = in[inPos++]; | ||
| case 16: | ||
| out[outPos++] = in[inPos++]; | ||
| case 15: | ||
| out[outPos++] = in[inPos++]; | ||
| case 14: | ||
| out[outPos++] = in[inPos++]; | ||
| case 13: | ||
| out[outPos++] = in[inPos++]; | ||
| case 12: | ||
| out[outPos++] = in[inPos++]; | ||
| case 11: | ||
| out[outPos++] = in[inPos++]; | ||
| case 10: | ||
| out[outPos++] = in[inPos++]; | ||
| case 9: | ||
| out[outPos++] = in[inPos++]; | ||
| case 8: | ||
| out[outPos++] = in[inPos++]; | ||
| case 7: | ||
| out[outPos++] = in[inPos++]; | ||
| case 6: | ||
| out[outPos++] = in[inPos++]; | ||
| case 5: | ||
| out[outPos++] = in[inPos++]; | ||
| case 4: | ||
| out[outPos++] = in[inPos++]; | ||
| case 3: | ||
| out[outPos++] = in[inPos++]; | ||
| case 2: | ||
| out[outPos++] = in[inPos++]; | ||
| case 1: | ||
| out[outPos++] = in[inPos++]; | ||
| case 0: | ||
| out[outPos++] = in[inPos++]; | ||
| int literalLen = ctrl + 1; | ||
| if (inPos > inEnd - literalLen || outPos > outEnd - literalLen) { | ||
| throw new LZFException("Corrupt data: truncated block"); | ||
| } | ||
| System.arraycopy(in, inPos, out, outPos, literalLen); | ||
| inPos += literalLen; | ||
| outPos += literalLen; |
Contributor
Author
There was a problem hiding this comment.
ai has benchmarked this to be faster and it's more maintainable
Contributor
Author
|
Superseded by #85 with the latest test cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LZFExceptionTests
./mvnw -Dtest=TestLZFDecoder test./mvnw test