skip_neutral_temps only if SMB's disabled#35
Merged
Conversation
log message for not skipping neutral temps while SMB's are possible
mountrcg
changed the title
dnzxy
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains an oref fix, which only enables skip_neutral_temps if SMB's are disabled (by whatever reason).
Reason being that the functionality only makes sense if the MDT pump cannot make any noise anyways and SMB's will always make the pump beep and rattle. So if SMBs can be given there is no reason to skip neutral temps to avoid beeps as it would be beeping because of an SMB.
However in current implementation enabling this function will always lead to all loops being skipped during the last 5 min of the hour. There is also a PR to TCD settings to explain this in more detail in Trio app https://github.com/tmhastings/Trio-dev/pull/5
Compare PR with oref PR discussion at openaps/oref0#1452 and issue ticket openaps/oref0#1451
Replaces PR #33