feat(TopBar): add a search messages button

[Jafetlch]

☑️ Resolves

The in-conversation message search is hard to find: the only way to reach it is through the right sidebar. This adds a search button to the conversation top bar that opens it directly.

While wiring the button I noticed showSidebar({ activeTab: 'search' }) landed on the participants tab, since 'search' is a content state and not a tab id. RightSidebar.handleUpdateActive now forwards 'search' to handleUpdateState('search').

The first version of this PR also bound Ctrl+F, removed after @Antreesy pointed out it is already taken by the conversation search in the left navigation.

AI (if applicable)

• The content of this PR was partly or fully generated using AI

Developed with Claude Code (claude-opus-4-8), commit carries the Assisted-by trailer. Reviewed and verified on a local Nextcloud 34 + Talk stable34 instance.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
• 🏗️ Changes to database schema — no
• 🔖 New/changed API endpoints — no

[nickvergessen]

Without looking at the code at all:

(search button visible in TopBar next to call button, sidebar opens to Search tab on click or Ctrl+F)

Please add screenshots to assist the review process

Also your commit is missing the DCO to confirm you did the changes and the license is okay:
https://github.com/nextcloud/server?tab=contributing-ov-file#sign-your-work

[Antreesy]

Besides, Ctrl+F is already taken by conversations search in left navigation: 6fce2eb
It's more a matter of giving it priority higher than the global Unified search

[Jafetlch]

Thanks for the feedback! I've updated the PR:

• Removed the Ctrl+F shortcut — as @Antreesy pointed out it's already bound to the conversation search in the left navigation. The PR is now just the discoverable TopBar button.
• Signed off the commit (DCO now passes).
• Added screenshots to the description (@nickvergessen).

One thing worth a look during review: the button needed a small change in RightSidebar as well — handleUpdateActive now routes the 'search' value to handleUpdateState('search'). Without it, showSidebar({ activeTab: 'search' }) fell back to the participants tab instead of opening the message search. Verified end-to-end on a local Nextcloud 34 + Talk stable34 build.

Happy to adjust the button placement or the approach if you'd prefer a different one.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[Antreesy]

Sorry, the PR got lost behind all the other work.
Code-wise it's good now, let us check with @nimishavijay for design input, whether we want to move the button completely from sidebar, or keep it in both places (I'd prefer the first option, but it's a change of user behvaiour)

[nimishavijay]

Nice! This is definitely an improvement for searching for messages and I'd prefer we remove it from the right sidebar too.

My only concern is that there's now 3 searches visible almost all the time on the screen. Considering we had discussed the possibility of combining it with the left search somehow, I'm wondering if directly implementing that makes more sense? What do you think @nickvergessen @Antreesy

[Antreesy]

of combining it with the left search somehow

My take would be still to have 'left search' as global (all messages across instance) and 'right search' as conversation-scoped

[Antreesy]

Please see review comments. I tried with these changes and pretty much satisfied with the result =)

[Antreesy]

Since there was no reply for two weeks, and we'd like to get this in, I rebased onto main and added additional changes to address review comments myself.
Pending for a second review