fix(express): stop replacing upstreaming error with 404#1728
Open
ArtemHoruzhenko wants to merge 1 commit into
Open
fix(express): stop replacing upstreaming error with 404#1728ArtemHoruzhenko wants to merge 1 commit into
ArtemHoruzhenko wants to merge 1 commit into
Conversation
kastov
reviewed
Oct 17, 2025
| if (isRouteExcluded(req, options.exclude)) { | ||
| const method = httpAdapter.getRequestMethod(req); | ||
| const url = httpAdapter.getRequestUrl(req); | ||
| return next(new NotFoundException(`Cannot ${method} ${url}`)); |
There was a problem hiding this comment.
Can't we just return next(err) instead of replacing exception?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If error happens in upstream middleware (e.g. bodyParser throws 413 error) for excluded routes 404 error will be generated which is confusing.
Issue Number: 1729
What is the new behavior?
Based on commit history found that it is ok to throw original error in case when it is HttpException instance and have "route exclusion" check below
Does this PR introduce a breaking change?
Other information
Addressing issue #1729