chore: extend attestation timeout - #4171
Conversation
| resolve_verification_tera_gas: 16, | ||
| // Must satisfy `Config::validate` (>= DEFAULT_EXPIRATION_DURATION_SECONDS). | ||
| launcher_hash_unused_ttl_seconds: 14 * 24 * 60 * 60, | ||
| launcher_hash_unused_ttl_seconds: 21 * 24 * 60 * 60, |
There was a problem hiding this comment.
Non-blocking nit: perhaps there’s a way to extract this number into a single place?
| } | ||
| #[test] |
There was a problem hiding this comment.
| } | |
| #[test] | |
| } | |
| #[test] |
| removed | ||
| } | ||
|
|
||
| pub(crate) fn extend_dstack_attestation_expiries(&mut self, extension: Duration) { |
There was a problem hiding this comment.
Maybe add a TODO to remove this temporary method once the nodes’ firmware is upgraded and the issue is resolved? Though it’ll probably be hard to miss anyway, since Clippy should complain at that point.
|
|
||
| let mut tee_state = old.tee_state; | ||
| tee_state.extend_dstack_attestation_expiries(Duration::from_secs( | ||
| mpc_attestation::attestation::DEFAULT_EXPIRATION_DURATION_SECONDS, |
There was a problem hiding this comment.
DEFAULT_EXPIRATION_DURATION_SECONDS is meant to represent the duration of an attestation, but .extend_dstack_attestation_expiries() adds it to whatever expiry we currently have, no?
| tee_verifier_votes: TeeVerifierVotes, | ||
| } | ||
|
|
||
| impl From<MpcContract> for crate::MpcContract { |
There was a problem hiding this comment.
Nice, I tend to only skim these boilerplate migration files, but in this PR, that’s actually where the relevant change lives.
|
closing in favor of #4172 |
3 participants
https://nearone.slack.com/archives/C0APULZJVHN/p1787037314757519