-
Notifications
You must be signed in to change notification settings - Fork 38
chore(test-utils): regenerate attestation fixtures with a retained signer key #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bdceeed
feat(cvm-deployment): optional PRELAUNCH_SCRIPT for test-asset collec…
pbeza a695d74
test(attestation): feature-gate the pre-launch-script rejection
pbeza 782e500
test(test-utils): regenerate attestation fixtures with a retained sig…
pbeza 6926a00
test(attestation): enable the script relaxation explicitly, and guard…
pbeza 9373733
refactor(attestation): gate the pre-launch-script check on a named const
pbeza 867dc5b
test(test-utils): simplify the collateral extraction in create-assets.sh
pbeza 69c7f1a
chore(mpc-attestation): restore cargo sort formatting of the abi feat…
pbeza 15850ee
test(attestation): address review on the fixture app-compose test
pbeza f70bbe7
chore(attestation): drop the feature-leak guard script
pbeza 713691b
chore(editorconfig): drop the borsh final-newline comment
pbeza d456633
test(localnet): commit the key-export hook used to collect the fixtures
pbeza a7d0e11
test(test-utils): regenerate the fixtures with the simplified export …
pbeza cb66673
Merge remote-tracking branch 'origin/main' into 3787-regenerate-fixtures
pbeza cb51a9e
chore(localnet): pass `PRELAUNCH_SCRIPT` as an absolute path
pbeza 5fa0480
test: note which tests require `allow-pre-launch-script`
pbeza e26eb67
chore: enable `allow-pre-launch-script` only for test builds
pbeza 19c0f66
Merge remote-tracking branch 'origin/main' into 3787-regenerate-fixtures
pbeza 7062936
refactor: export the fixture signer key through the launcher compose
pbeza 2f71c86
test(test-utils): derive the fixture public key when checking the pair
pbeza 46a1331
Merge remote-tracking branch 'origin/main' into 3787-regenerate-fixtures
pbeza 9ace193
Merge remote-tracking branch 'origin/main' into 3787-regenerate-fixtures
pbeza 246c1e6
docs: fix the fixture-collection hand-off and trim the asset docs
pbeza bf56c7e
Merge remote-tracking branch 'origin/main' into 3787-regenerate-fixtures
pbeza 3118b2a
docs: address review wording on the asset and single-node readmes
pbeza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -487,6 +487,23 @@ impl AllowedLauncherImages { | |
| .find(|e| &e.launcher_hash == launcher_hash) | ||
| .map(|e| e.expires_at.as_secs()) | ||
| } | ||
|
|
||
| /// Test-only: allows one more compose hash for an already-allowed launcher. The attestation | ||
| /// fixture is captured from a CVM whose launcher compose carries a key-export service, so | ||
| /// [`get_docker_compose_hash`] cannot derive its hash. | ||
| #[cfg(test)] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice |
||
| pub(crate) fn allow_compose_hash( | ||
| &mut self, | ||
| launcher_hash: &LauncherImageHash, | ||
| compose_hash: LauncherDockerComposeHash, | ||
| ) { | ||
| self.entries | ||
| .iter_mut() | ||
| .find(|e| &e.launcher_hash == launcher_hash) | ||
| .expect("launcher must be allowed first") | ||
| .compose_hashes | ||
| .push(compose_hash); | ||
| } | ||
| } | ||
|
|
||
| /// Given a launcher image hash and MPC docker image hash, compute the launcher docker compose hash | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you revert it, you'll get this error:
Explained by Claude: