fix: short circuit on participant network partition - #4075
Open
metalurgical wants to merge 3 commits into
Open
Conversation
Implements an early return when a participant waiting for a connection exceeds the introduced timeout and deems the other participant unreachable, informing the leader of this so it can short circuit as well instead of waiting for eventual failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an early return when a participant waiting for a connection exceeds the introduced timeout and deems the other participant unreachable, informing the leader of this so it can short circuit as well instead of waiting for eventual failure. Afaict, applies to all compute calls, both asset generation and signing.
Fix is deliberately simple, a heartbeat-style network connectivity graph could be considered as a future upgrade.
Related to #1207