-
Notifications
You must be signed in to change notification settings - Fork 38
feat: probe Aptos providers by ledger chain id #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f2342e9
feat(probe): probe Aptos for its ledger chain id
haiyuechen-nearone 1349d6f
fix(probe): report a slow Aptos provider as timed out
haiyuechen-nearone 62581d4
refactor(probe): derive the attempt deadline once
haiyuechen-nearone 81bac79
docs(probe): state the 404 contract once, on the classifier
haiyuechen-nearone ca106c7
Revert "refactor(probe): derive the attempt deadline once"
haiyuechen-nearone 103041f
docs(probe): move the DI todo to where the clients are chosen
haiyuechen-nearone 14ad249
docs(probe): shorten the DI todo and fold it into the doc comment
haiyuechen-nearone ce2b951
refactor(probe): let the resource say what a not found answer means
haiyuechen-nearone 13480cc
fix(probe): tell a body that never arrived from one that is not the r…
haiyuechen-nearone 02ad7ff
refactor(probe): enforce the absence meaning on the trait
haiyuechen-nearone 3061134
docs(probe): cut the paraphrasing Aptos comments
haiyuechen-nearone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we could reuse
"1"below in the// Thensection if we extract it into a variable.