Skip to content

dev: Add deposit-address best practice #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Y3drk merged 4 commits into from
Jun 19, 2026
Merged

dev: Add deposit-address best practice #233

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16ed23d
Action Item 1
Y3drk Jun 18, 2026
189b60c
Action Item 2
Y3drk Jun 18, 2026
c1d7bd2
Apply 06/18/26 GitHub review feedback & AI agents' suggestions, pt.1
Y3drk Jun 19, 2026
90cf0d1
Apply AI agents' suggestions, pt.2
Y3drk Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ For reference see [ensawards.org/data/ens-best-practices/contract-naming/name-yo
[ensawards.org/data/ens-best-practices/types.ts](ensawards.org/data/ens-best-practices/types.ts) file.
```typescript
export interface BestPracticeTechnicalDetails {
useCaseSummary: JSX.Element;
ensBestPracticeOverview: JSX.Element;
benefitFromUsingEns: JSX.Element;
/** Title for the benefit card. Defaults to "Benefit from using ENS" when omitted. */
benefitFromUsingEnsTitle?: string;
Expand Down Expand Up @@ -309,6 +309,9 @@ For reference, see [ensawards.org/data/ens-best-practices/contract-naming/name-y
examplePartialPass?: AcceptanceTestBenchmarkPartialPass;
exampleFail?: AcceptanceTestBenchmarkFail;
exampleNotApplicable?: NotApplicableAcceptanceTestBenchmark;

/** Sort priority within a {@link BestPractice}; lower comes first, undefined sorts last (then by name). */
order?: number;
Comment thread
Y3drk marked this conversation as resolved.
Outdated
}
```
4. In your PR describe your reasoning for adding it.
Expand Down
69 changes: 69 additions & 0 deletions ensawards.org/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,75 @@ export default defineConfig({
"/ens-best-practices/contract-naming": "/ens-best-practices",

"/leaderboards/defi": "/leaderboards/defi-protocol",

// The `ensv2-readiness` best practice category was renamed to `resolution`.
"/ens-best-practices/ensv2-readiness/ensv2-ready-resolution":
"/ens-best-practices/resolution/ensv2-ready-resolution",

"/app/1inch-defi/ensv2-readiness/ensv2-ready-resolution":
"/app/1inch-defi/resolution/ensv2-ready-resolution",
"/app/aave-defi/ensv2-readiness/ensv2-ready-resolution":
"/app/aave-defi/resolution/ensv2-ready-resolution",
"/app/ambire-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/ambire-wallet/resolution/ensv2-ready-resolution",
"/app/binance-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/binance-exchange/resolution/ensv2-ready-resolution",
"/app/binance-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/binance-wallet/resolution/ensv2-ready-resolution",
"/app/blockscout-explorer/ensv2-readiness/ensv2-ready-resolution":
"/app/blockscout-explorer/resolution/ensv2-ready-resolution",
"/app/coinbase-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/coinbase-exchange/resolution/ensv2-ready-resolution",
"/app/coinbase-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/coinbase-wallet/resolution/ensv2-ready-resolution",
"/app/cryptocom-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/cryptocom-exchange/resolution/ensv2-ready-resolution",
"/app/cryptocom-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/cryptocom-wallet/resolution/ensv2-ready-resolution",
"/app/etherscan-explorer/ensv2-readiness/ensv2-ready-resolution":
"/app/etherscan-explorer/resolution/ensv2-ready-resolution",
"/app/frame-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/frame-wallet/resolution/ensv2-ready-resolution",
"/app/gemini-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/gemini-wallet/resolution/ensv2-ready-resolution",
"/app/kraken-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/kraken-exchange/resolution/ensv2-ready-resolution",
"/app/kraken-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/kraken-wallet/resolution/ensv2-ready-resolution",
"/app/lido-defi/ensv2-readiness/ensv2-ready-resolution":
"/app/lido-defi/resolution/ensv2-ready-resolution",
"/app/metamask-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/metamask-wallet/resolution/ensv2-ready-resolution",
"/app/okx-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/okx-exchange/resolution/ensv2-ready-resolution",
"/app/okx-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/okx-wallet/resolution/ensv2-ready-resolution",
"/app/phantom-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/phantom-wallet/resolution/ensv2-ready-resolution",
"/app/rabby-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/rabby-wallet/resolution/ensv2-ready-resolution",
"/app/rainbow-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/rainbow-wallet/resolution/ensv2-ready-resolution",
"/app/readyx-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/readyx-wallet/resolution/ensv2-ready-resolution",
"/app/robinhood-exchange/ensv2-readiness/ensv2-ready-resolution":
"/app/robinhood-exchange/resolution/ensv2-ready-resolution",
"/app/robinhood-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/robinhood-wallet/resolution/ensv2-ready-resolution",
"/app/safe-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/safe-wallet/resolution/ensv2-ready-resolution",
"/app/status-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/status-wallet/resolution/ensv2-ready-resolution",
"/app/trust-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/trust-wallet/resolution/ensv2-ready-resolution",
"/app/uniswap-defi/ensv2-readiness/ensv2-ready-resolution":
"/app/uniswap-defi/resolution/ensv2-ready-resolution",
"/app/walletchan-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/walletchan-wallet/resolution/ensv2-ready-resolution",
"/app/worldapp-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/worldapp-wallet/resolution/ensv2-ready-resolution",
"/app/zerion-wallet/ensv2-readiness/ensv2-ready-resolution":
"/app/zerion-wallet/resolution/ensv2-ready-resolution",
},

adapter: vercel(),
Expand Down
3 changes: 3 additions & 0 deletions ensawards.org/data/acceptance-tests/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export interface AcceptanceTest {
examplePartialPass?: AcceptanceTestBenchmarkPartialPass;
exampleFail?: AcceptanceTestBenchmarkFail;
exampleNotApplicable?: AcceptanceTestBenchmarkNotApplicable;

/** Sort priority within a {@link BestPractice}; lower comes first, undefined sorts last (then by name). */
order?: number;
Comment thread
Y3drk marked this conversation as resolved.
Outdated
}

/**
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/1inch-defi/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
Comment on lines +58 to +67
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(OneInchDeFi, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/aave-defi/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(AaveDeFi, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/ambire-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ const benchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
Comment on lines +70 to +79

@coderabbitai coderabbitai Bot Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Benchmark stubs are still incomplete for merge readiness.

All deposit-addresses tests are undefined, so this app has no executable benchmark outcomes for the new best practice yet. That conflicts with the stated pre-merge requirement to include all necessary benchmark components.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ensawards.org/data/apps/ambire-wallet/benchmarks/index.tsx` around lines 70 -
79, The deposit-addresses benchmark object contains multiple test entries
(correctly-resolve-direct-onchain-subname-address,
correctly-resolve-names-requiring-normalization,
correctly-implement-ccip-read-for-eth-subnames,
correctly-implement-ccip-read-for-offchain-dns-names,
correctly-resolve-names-for-different-evm-chains,
correctly-resolve-names-for-bitcoin, correctly-resolve-names-for-solana,
correctly-handle-resolution-for-chains-with-invalid-address-formatting) that are
all set to undefined. Replace each undefined value with the actual benchmark
test implementation or function that performs the respective test, ensuring each
benchmark has executable logic rather than placeholder values.

@Y3drk Y3drk Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These benchmarks will be filled/performed in the few following days.

@coderabbitai coderabbitai Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Y3drk Understood, thanks for the heads-up! Since this is a draft PR and the merge pre-condition explicitly requires all benchmarks to be included before merging, the undefined placeholders are fine for now. Just make sure to flip the PR out of draft once all eight acceptance test benchmarks for deposit-addresses are filled in across all tracked apps. I'll keep this comment open until then.

🧠 Learnings used 
Learnt from: Y3drk
Repo: namehash/ensawards PR: 117
File: ensawards.org/src/components/atoms/icons/ens-integrating-entities/apps/CoinbaseWalletIcon.tsx:11-12
Timestamp: 2026-02-04T14:50:19.321Z
Learning: In TSX components, when a component applies inline styles (style={{...}}) and later spreads props ({...props}) after, allow that spread to override the inline styles if this ordering is intentional and consistent with the project’s styling approach (e.g., Tailwind via className). Document and enforce this convention in code reviews to prevent accidental overrides and ensure the behavior is intentional across components.

Learnt from: Y3drk
Repo: namehash/ensawards PR: 204
File: ensawards.org/data/apps/metamask-wallet/benchmarks/index.tsx:25-25
Timestamp: 2026-05-12T06:57:59.413Z
Learning: In benchmark files like `ensawards.org/data/apps/<app>/benchmarks/index.tsx`, don’t flag identical `parseTimestamp(...)` results as copy-paste errors when they appear across multiple benchmark entries for the same contributor. For `lastUpdated` in these benchmarks, only the calendar date is meaningful; exact hour/minute/second precision is not significant. It’s acceptable for entries sharing the same contributor/date to have the same normalized timestamp—only flag if the timestamps differ in a way that indicates an unintended date mismatch (e.g., wrong day for the contributor).

Learnt from: Y3drk
Repo: namehash/ensawards PR: 204
File: ensawards.org/data/apps/rainbow-wallet/benchmarks/index.tsx:19-24
Timestamp: 2026-05-12T06:59:04.010Z
Learning: In `ensawards.org/data/apps/*/benchmarks/index.tsx`, do not treat intentionally preserved, commented-out benchmark blocks (e.g., `

Learnt from: Y3drk
Repo: namehash/ensawards PR: 204
File: ensawards.org/src/components/molecules/technicalDetails/benchmark/acceptanceTestResultDetails.tsx:19-24
Timestamp: 2026-05-12T16:07:54.248Z
Learning: In this TypeScript/React codebase, if a contributions-like field is typed as a non-empty tuple (e.g., `[Contribution, ...Contribution[]]`), it is guaranteed at compile time to have at least one element. In code reviews, do not flag potential empty-array risks for that field, and rely on the non-empty tuple type (and any existing unit tests that assert the runtime invariant) instead.

} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(AmbireWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/binance-exchange/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(BinanceExchange, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/binance-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(BinanceWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/blockscout-explorer/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ const benchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(BlockscoutExplorer, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/coinbase-exchange/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(CoinbaseExchange, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/coinbase-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ const benchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(CoinbaseWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/cryptocom-exchange/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(CryptoComExchange, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/cryptocom-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(CryptoComWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/etherscan-explorer/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ const benchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(EtherscanExplorer, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/frame-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(FrameWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/gemini-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(GeminiWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/kraken-exchange/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(KrakenExchange, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/kraken-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
};

defineAppBenchmarks(KrakenWallet, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/lido-defi/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@ const benchmarks: BestPracticeBenchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(LidoDeFi, benchmarks);
Expand Down
10 changes: 10 additions & 0 deletions ensawards.org/data/apps/metamask-wallet/benchmarks/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,16 @@ const benchmarks = {
),
} as const satisfies AcceptanceTestBenchmark,
},
"deposit-addresses": {
"correctly-resolve-direct-onchain-subname-address": undefined,
"correctly-resolve-names-requiring-normalization": undefined,
"correctly-implement-ccip-read-for-eth-subnames": undefined,
"correctly-implement-ccip-read-for-offchain-dns-names": undefined,
"correctly-resolve-names-for-different-evm-chains": undefined,
"correctly-resolve-names-for-bitcoin": undefined,
"correctly-resolve-names-for-solana": undefined,
"correctly-handle-resolution-for-chains-with-invalid-address-formatting": undefined,
},
} as const satisfies BestPracticeBenchmarks;

defineAppBenchmarks(MetaMaskWallet, benchmarks);
Expand Down
Loading
Loading