Bug 2054039 - Add a button to clear all screen notifications#9687
Open
davidmiculit wants to merge 2 commits into
Open
Bug 2054039 - Add a button to clear all screen notifications#9687davidmiculit wants to merge 2 commits into
davidmiculit wants to merge 2 commits into
Conversation
esanuandra
reviewed
Jul 10, 2026
Comment on lines
+34
to
+40
| <Button | ||
| onClick={() => clearAllNotifications()} | ||
| className="clear-all-notifications w-100 mb-1" | ||
| size="sm" | ||
| > | ||
| Clear all notifications | ||
| </Button> |
Collaborator
There was a problem hiding this comment.
Functionality is all right
That blue background stands out too much imo, this styling is used for tags.
I would go for maybe variant="darker-info", it looks better on jobs view, it overlaps with Table view and Add test data buttons in graphs view, I'm not sure. What do you think?
Or something that is not that bright in color and is similar with the other buttons in Perfherder.
Collaborator
There was a problem hiding this comment.
Maybe we could add a keyboard shortcut for this
Collaborator
Author
There was a problem hiding this comment.
I agree that it could look better, but the overlapping will still be present as long as any notifications are on screen(even without the clear all button), so that can't be helped
esanuandra
requested changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2054039 - Add a button to clear all screen notifications