docs(openspec): add-single-gpu-session-ai-review-mvp 標記 deferred - #415
Conversation
2026-07-28 使用者裁決:48/49 未動工、全 archive 違反 openspec/AGENTS.md(unfinished 不得 archive);標 deferred+盤點分類(機制層已被 diff_engine/a4/bcf_writer/rule_engine 取代;獨有主線=GPU 量測 harness+回收倒數,另切小 change 承接後做 crosswalk)。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bi4ujiFajBbd4nRhayJFxe
📝 WalkthroughWalkthroughThe proposal is marked deferred, records that tasks 48/49 have not started, classifies inventoried work, and defines conditions for thawing and restarting implementation. ChangesMVP deferment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openspec/changes/add-single-gpu-session-ai-review-mvp/proposal.md`:
- Line 1: Update the thaw condition in the change status note to consistently
use the explicit successor change ID gpu-session-baseline-and-idle-reclaim
instead of the ambiguous “T1” label. Preserve the requirement to complete that
successor change before thawing and performing the crosswalk, while retaining
the separate explicit-user-thaw alternative.
- Line 1: 補跑全 repository 的 `npx openspec validate --all --strict`，並將實際通過或失敗結果記錄到
proposal.md 的重啟條件；同時保留既有 change-specific strict validation 要求，若無法執行則明確記錄缺少
npm/openspec 環境，不要宣稱已通過。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a7faa21-e7b4-42ca-8339-5093933e2c83
📒 Files selected for processing (1)
openspec/changes/add-single-gpu-session-ai-review-mvp/proposal.md
| @@ -1,3 +1,5 @@ | |||
| > **Status: deferred 2026-07-28**（使用者裁決）。不計入 active WIP；解凍前不做實作。48/49 task 未動工且無任何實作 commit；依 2026-07-28 read-only 盤點分類：(a) **機制層已被既有落地取代**——冪等/指紋對齊階梯＝`governance-service/diff_engine/keys.py`（`model-version-diff-authority`）、「人審 gate、不自動建 issue」語意＝a4 change tasks 4.x/5.5＋PR #398、BCFzip serializer 骨架＝`bcf/bcf_writer.py`（BCF 2.1，`governance-bcf-export`）、checker→批次 issue 骨架＝`rule_engine/`（`governance-rule-run-authority`）、task 7.5 凍結三檔回歸＝repo 常設鐵律；(b) **真正無人認領的獨有主線**＝Phase 0 GPU 量測 harness（1.1–1.5）與 2.11 無互動回收倒數，規劃另切小 change（暫名 `gpu-session-baseline-and-idle-reclaim`）承接，屆時對本 change 做 requirement/successor crosswalk；(c) IfcClash/LLM 草稿管線、人審 triage 佇列、BCF-API 3.0 端點維持凍結待裁。重啟條件：T1 小 change 落地後 thaw 做 crosswalk，或使用者明確 thaw；重啟時須重跑 `npx openspec validate add-single-gpu-session-ai-review-mvp --strict` 並重驗上列 supersede 證據仍成立。 | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
使用明確的 successor change ID，避免 thaw 條件歧義。
此段先命名 gpu-session-baseline-and-idle-reclaim，後續卻改稱「T1 小 change」；若 T1 不是既有正式別名，解凍條件可能無法判定。請直接使用完整 change ID，或在此明確定義 T1。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openspec/changes/add-single-gpu-session-ai-review-mvp/proposal.md` at line 1,
Update the thaw condition in the change status note to consistently use the
explicit successor change ID gpu-session-baseline-and-idle-reclaim instead of
the ambiguous “T1” label. Preserve the requirement to complete that successor
change before thawing and performing the crosswalk, while retaining the separate
explicit-user-thaw alternative.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
npx openspec validate --all --strictRepository: monkey1sai/AI-BIM-governance
Length of output: 643
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Tracked files mentioning openspec status/validation:"
rg -n "npx openspec validate|Status: deferred|Status: active|npx openspec validate --all --strict" -S . || true
echo
echo "Target proposal relevant status lines:"
sed -n '1,40p' openspec/changes/add-single-gpu-session-ai-review-mvp/proposal.md
echo
echo "Package manager files:"
git ls-files | rg '(^|/)(package.json|package-lock.json|pnpm-lock.yaml|yarn.lock|bun.lockb)$' || true
echo
echo "Top-level package scripts:"
if [ -f package.json ]; then
cat package.json | python3 -c 'import json,sys; d=json.load(sys.stdin); print("scripts:", d.get("scripts",{}), "devDependencies:", {k:v for k,v in d.get("devDependencies",{}).items() if "openspec" in k.lower() or "codex" in k.lower()}, "dependencies:", {k:v for k,v in d.get("dependencies",{}).items() if "openspec" in k.lower() or "codex" in k.lower()})'
fiRepository: monkey1sai/AI-BIM-governance
Length of output: 14433
補齊 npx openspec validate --all --strict 驗證結果。
此 deferred change 的重啟條件和 repo guideline 都要求全 repository strict validation；目前 proposal 僅記錄 change-specific validation。請補跑並將結果記錄到重啟條件，或直接由具備 npm/openspec 環境者提供通過證據。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openspec/changes/add-single-gpu-session-ai-review-mvp/proposal.md` at line 1,
補跑全 repository 的 `npx openspec validate --all --strict`，並將實際通過或失敗結果記錄到
proposal.md 的重啟條件；同時保留既有 change-specific strict validation 要求，若無法執行則明確記錄缺少
npm/openspec 環境，不要宣稱已通過。
Source: Coding guidelines
There was a problem hiding this comment.
Pull request overview
This PR marks the umbrella OpenSpec change add-single-gpu-session-ai-review-mvp as Status: deferred 2026-07-28 by user decision. The change had 48/49 tasks unstarted with zero implementation commits and was the only bare active change lacking a status marker. Marking it deferred (rather than archiving it, which would violate openspec/AGENTS.md's "archive only completed changes" rule and repeat the error corrected in PR #404) keeps it out of the active WIP count while preserving its unfinished tasks and recording the inventory classification (mechanism-layer superseded evidence, the genuinely unclaimed GPU-measurement mainline, and a planned successor crosswalk) plus restart conditions.
Changes:
- Adds a two-line
Status: deferredblockquote to the top of the proposal, following the existing deferred-change convention. - Documents supersede evidence, the unclaimed GPU-baseline mainline (to be sliced into a future
gpu-session-baseline-and-idle-reclaimchange), and explicit thaw/restart conditions. - Leaves
tasks.md,design.md, and specs untouched.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fed3413024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,3 +1,5 @@ | |||
| > **Status: deferred 2026-07-28**（使用者裁決）。不計入 active WIP；解凍前不做實作。48/49 task 未動工且無任何實作 commit；依 2026-07-28 read-only 盤點分類：(a) **機制層已被既有落地取代**——冪等/指紋對齊階梯＝`governance-service/diff_engine/keys.py`（`model-version-diff-authority`）、「人審 gate、不自動建 issue」語意＝a4 change tasks 4.x/5.5＋PR #398、BCFzip serializer 骨架＝`bcf/bcf_writer.py`（BCF 2.1，`governance-bcf-export`）、checker→批次 issue 骨架＝`rule_engine/`（`governance-rule-run-authority`）、task 7.5 凍結三檔回歸＝repo 常設鐵律；(b) **真正無人認領的獨有主線**＝Phase 0 GPU 量測 harness（1.1–1.5）與 2.11 無互動回收倒數，規劃另切小 change（暫名 `gpu-session-baseline-and-idle-reclaim`）承接，屆時對本 change 做 requirement/successor crosswalk；(c) IfcClash/LLM 草稿管線、人審 triage 佇列、BCF-API 3.0 端點維持凍結待裁。重啟條件：T1 小 change 落地後 thaw 做 crosswalk，或使用者明確 thaw；重啟時須重跑 `npx openspec validate add-single-gpu-session-ai-review-mvp --strict` 並重驗上列 supersede 證據仍成立。 | |||
There was a problem hiding this comment.
When this deferred change is later split, this inventory will drop the core Phase 1 work: tasks 2.1–2.10 are all unchecked, and a repo-wide search finds no SessionBroker, SingleGpuDriver, or equivalent implementation, yet the new status says the only genuinely unowned track is Phase 0 plus task 2.11 and proposes gpu-session-baseline-and-idle-reclaim as the successor. Admission control, the primary queue, TTL/health recovery, and cold-start polling consequently have no stated future owner, allowing the proposal's primary user goal to silently fall out of planning; include these gaps in the frozen/unowned classification or assign them to an explicit successor.
AGENTS.md reference: AGENTS.md:L131-L139
Useful? React with 👍 / 👎.
| @@ -1,3 +1,5 @@ | |||
| > **Status: deferred 2026-07-28**（使用者裁決）。不計入 active WIP；解凍前不做實作。48/49 task 未動工且無任何實作 commit；依 2026-07-28 read-only 盤點分類：(a) **機制層已被既有落地取代**——冪等/指紋對齊階梯＝`governance-service/diff_engine/keys.py`（`model-version-diff-authority`）、「人審 gate、不自動建 issue」語意＝a4 change tasks 4.x/5.5＋PR #398、BCFzip serializer 骨架＝`bcf/bcf_writer.py`（BCF 2.1，`governance-bcf-export`）、checker→批次 issue 骨架＝`rule_engine/`（`governance-rule-run-authority`）、task 7.5 凍結三檔回歸＝repo 常設鐵律；(b) **真正無人認領的獨有主線**＝Phase 0 GPU 量測 harness（1.1–1.5）與 2.11 無互動回收倒數，規劃另切小 change（暫名 `gpu-session-baseline-and-idle-reclaim`）承接，屆時對本 change 做 requirement/successor crosswalk；(c) IfcClash/LLM 草稿管線、人審 triage 佇列、BCF-API 3.0 端點維持凍結待裁。重啟條件：T1 小 change 落地後 thaw 做 crosswalk，或使用者明確 thaw；重啟時須重跑 `npx openspec validate add-single-gpu-session-ai-review-mvp --strict` 並重驗上列 supersede 證據仍成立。 | |||
There was a problem hiding this comment.
For cross-version AI findings, diff_engine/keys.py only aligns IFC elements by GlobalId, Tag, or type/name/location; it does not implement unchecked tasks 4.1–4.6's calibrated rule-plus-geometry fingerprints, guid_churn_suspected human routing, parent/child convergence, resolved/reopen lineage, or four-way difference report, and a repo-wide search finds no equivalent implementation. Classifying the fingerprint mechanism as already replaced while omitting issue-idempotency from the frozen tracks can therefore cause a later successor crosswalk to discard an entire unimplemented capability as superseded; retain it explicitly as frozen/unowned or name its actual successor.
AGENTS.md reference: AGENTS.md:L131-L139
Useful? React with 👍 / 👎.
| @@ -1,3 +1,5 @@ | |||
| > **Status: deferred 2026-07-28**（使用者裁決）。不計入 active WIP；解凍前不做實作。48/49 task 未動工且無任何實作 commit；依 2026-07-28 read-only 盤點分類：(a) **機制層已被既有落地取代**——冪等/指紋對齊階梯＝`governance-service/diff_engine/keys.py`（`model-version-diff-authority`）、「人審 gate、不自動建 issue」語意＝a4 change tasks 4.x/5.5＋PR #398、BCFzip serializer 骨架＝`bcf/bcf_writer.py`（BCF 2.1，`governance-bcf-export`）、checker→批次 issue 骨架＝`rule_engine/`（`governance-rule-run-authority`）、task 7.5 凍結三檔回歸＝repo 常設鐵律；(b) **真正無人認領的獨有主線**＝Phase 0 GPU 量測 harness（1.1–1.5）與 2.11 無互動回收倒數，規劃另切小 change（暫名 `gpu-session-baseline-and-idle-reclaim`）承接，屆時對本 change 做 requirement/successor crosswalk；(c) IfcClash/LLM 草稿管線、人審 triage 佇列、BCF-API 3.0 端點維持凍結待裁。重啟條件：T1 小 change 落地後 thaw 做 crosswalk，或使用者明確 thaw；重啟時須重跑 `npx openspec validate add-single-gpu-session-ai-review-mvp --strict` 並重驗上列 supersede 證據仍成立。 | |||
There was a problem hiding this comment.
The cited bcf/bcf_writer.py is not a replacement for task 6.4: both its implementation and the canonical governance-bcf-export spec explicitly emit BCF 2.1, while the proposed BCF-XML 3.0 serializer, official-XSD validation, JSON/BCFzip consistency check, and desktop-tool smoke remain entirely unchecked. Because the new inventory treats the 2.1 skeleton as replaced mechanism and only names BCF-API 3.0 endpoints—not the separately approved BCF-XML 3.0 archive—as frozen, a future crosswalk can silently lose this user-approved deliverable; list the 3.0 serializer explicitly as retained work or assign it to a successor.
AGENTS.md reference: AGENTS.md:L131-L139
Useful? React with 👍 / 👎.
目的
add-single-gpu-session-ai-review-mvp標記Status: deferred 2026-07-28(使用者本日明確裁決)。背景:此傘型 change 48/49 task 未動工、零實作 commit,且是唯一無 Status 標記的裸 active change(NOW.md:63 早已註記「另案裁決」)。2026-07-28 read-only 盤點證實:全 archive 違反
openspec/AGENTS.md(MUST 僅 archive 已完成 change;約 23 個 task 無 successor 可標 terminal disposition)——7/24 才剛為同類錯誤做過 historical correction(#404),不重蹈。Status 段落內含盤點分類(機制層 supersede 證據:
diff_engine/keys.py、a4 tasks 4.x/5.5+PR #398、bcf_writer.py、rule_engine/;獨有主線=GPU 量測 harness 1.1–1.5+2.11 回收倒數,規劃另切gpu-session-baseline-and-idle-reclaim小 change 承接)與重啟條件,格式對齊既有四個 deferred change(align/cross-service/minio-folderview/rvt)的慣例。Change Classification
驗證
npx openspec validate add-single-gpu-session-ai-review-mvp --strict→ validgit diff --check乾淨🤖 Generated with Claude Code
https://claude.ai/code/session_01Bi4ujiFajBbd4nRhayJFxe
Summary by CodeRabbit