Skip to content

[fix #129] Fix register/de-register bug when process is restarted out-of-band. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apinstein wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix #129] Fix register/de-register bug when process is restarted out-of-band. #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/god/conditions/process_exits.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def valid?
end

def pid
self.pid_file ? File.read(self.pid_file).strip.to_i : self.watch.pid
# only read pid once since lazy evaluation can cause bugs due to changing external state
@pid ||= self.pid_file ? File.read(self.pid_file).strip.to_i : self.watch.pid
end

def register
Expand All @@ -50,6 +51,8 @@ def register

def deregister
pid = self.pid
@pid = nil # reset so that @pid will bootstrap itself again as needed

if pid
EventHandler.deregister(pid, :proc_exit)

Expand Down