De-flake conformance CI: solo re-verification, spawn-storm reduction, result artifacts - #3043
Merged
Claude / Claude Code Review
completed
Jul 1, 2026 in 19m 11s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | .github/actions/conformance/run-client.sh:55-59 |
pipefail + grep -q makes stale-baseline guard fail open on large logs |
Annotations
Check warning on line 59 in .github/actions/conformance/run-client.sh
claude / Claude Code Review
pipefail + grep -q makes stale-baseline guard fail open on large logs
Under `set -uo pipefail`, the stale-baseline guard `printf '%s\n' "$plain" | grep -q '^Stale baseline entries'` can return 141 (SIGPIPE on the printf side) instead of 0 when more than a pipe buffer (~64KB) of log text follows the heading — so the guard is skipped exactly when the pattern IS present, and the solo reruns can green-wash a stale-baseline configuration error. Avoid the pipe, e.g. `if grep -q '^Stale baseline entries' <<<"$plain"; then` (or grep the stripped log file directly).
Loading