Fix concatenating epochs cropped after baseline correction - #14188
Merged
Conversation
kalomak
marked this pull request as ready for review
August 22, 2026 11:04
kalomak
requested review from
agramfort,
drammock,
larsoner and
mscheltienne
as code owners
August 22, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #12153.
What does this implement/fix?
Fixes
concatenate_epochsfailing on epochs cropped after baseline correction.Before this change, concatenation passed the original baseline to the
EpochsArrayconstructor. The constructor rejected it because the baseline period was outside the cropped time range.This uses the same approach as
_evoked_from_epoch_data(): construct the result without baseline correction, then restore the original baseline metadata.This means that
mne.concatenate_epochsdoes not apply baseline correction when creating the newEpochsArray.Pending baseline corrections are already applied when the input epoch data are loaded earlier in the function.