Add Limit node to pframe QuerySpec/QueryData - #1761
Open
vadimpiven wants to merge 3 commits into
Open
Conversation
Mirror the QueryLimit node from pframes-rs 1.1.57 in the TS query types (QueryLimit interface, spec/data aliases, traversal and comparison).
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🦋 Changeset detectedLatest commit: a11c745 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Add the pFrameQueryLimitSupport runtime feature flag and cap data-table queries at 50k rows via the new limit query node when the desktop's pframe engine supports it (older runtimes fall back to no limit).
Every per-package software build calls ensureEcrLogin unconditionally, and turbo fans those out as separate processes. N concurrent 'docker login' to the same registry race on the shared credential store (macOS keychain: -25299). Serialize the login across processes with a cross-process file lock (fd-lock) keyed by host; builds and pushes stay parallel.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 49.57% 53.43% +3.86%
==========================================
Files 70 366 +296
Lines 3786 19679 +15893
Branches 969 4338 +3369
==========================================
+ Hits 1877 10516 +8639
- Misses 1640 7862 +6222
- Partials 269 1301 +1032 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xnacly
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the
QueryLimitnode added in pframes-rs 1.1.57.Changes
QueryLimit<Q>interface inquery_common.ts(type: "limit",input,fetch)SpecQueryLimit/DataQueryLimitaliases + union memberslimithandled intraverseQuerySpec(input passthrough) andcmpQuerySpec(compares input, thenfetch)spec_override_collapse.tsneeds no change — itsdefaultbranch already rejectslimitas unsupported, matching sort/filter.Greptile Summary
This PR mirrors the
QueryLimitnode introduced inpframes-rs 1.1.57by adding the corresponding TypeScript types and plumbing across the query layer. The implementation is clean and consistent with how existing wrapper nodes (filter,sort,sliceAxes) are handled.QueryLimit<Q>generic interface inquery_common.ts, withDataQueryLimitandSpecQueryLimit<C>aliases added to the respective union types.traverseQuerySpec—"limit"falls into the existing input-passthrough group;cmpQuerySpecgains a properlimitcase that comparesinputfirst and thenfetch.pframes-rs-node,pframes-rs-wasip2, andpframes-rs-wasmupdated from1.1.56to1.1.57;REQUIRES_PFRAMES_VERSIONis intentionally left unchanged per the workspace convention (updated later to give desktop time to catch up).Confidence Score: 4/5
Safe to merge — the change is a straightforward type-layer addition with correct traversal and comparison logic.
The new limit node is wired up correctly in both traverseQuerySpec (input passthrough, identical to filter/sort) and cmpQuerySpec (compares input then fetch). The only gap is that utils.test.ts has no test exercising the limit path in traverseQuerySpec, so a future accidental breakage in that branch would go undetected.
utils.ts and utils.test.ts — the new limit case in traverseQuerySpec lacks a matching test.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["SpecQuery / DataQuery Union"] -->|new member| B["SpecQueryLimit / DataQueryLimit"] B --> C["QueryLimit (query_common.ts)"] C --> D["type: 'limit'"] C --> E["input: Q"] C --> F["fetch: number"] G["traverseQuerySpec"] -->|fall-through group| H["'filter' | 'sort' | 'limit' | 'sliceAxes' | .."] H --> I["result = { ...query, input: traverseQuerySpec(query.input, visitor) }"] J["cmpQuerySpec"] -->|case 'limit'| K["cmpQuerySpec(lhs.input, rhs.input)"] K -->|cmp !== 0| L["return cmp"] K -->|cmp === 0| M["return lhs.fetch - rhs.fetch"] N["pframes-rs catalog"] -->|bump 1.1.56 to 1.1.57| O["node / wasip2 / wasm"]Reviews (1): Last reviewed commit: "Add Limit node to pframe QuerySpec/Query..." | Re-trigger Greptile