[WIP] Run virtio-villain tests via petri in CI

[jstarks]

No description provided.

[Copilot]

Pull request overview

Adds a new “virtio-villain” (guest-side virtio fault-injection / conformance) test suite runner that boots OpenVMM under petri, then wires it into Flowey pipelines and PR CI so results (JUnit + per-test petri logs) can be collected and published.

Changes:

• Introduces virtio_villain_tests crate: parses tests.tsv, runs one VM per villain test via petri, and surfaces results via libtest-mimic.
• Extends petri logging to support creating additional per-test log roots after global tracing is initialized.
• Adds Flowey nodes/jobs/pipelines + CI wiring to build a nextest archive and run it on KVM runners, publishing logs for logview.

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vmm_tests/virtio_villain_tests/tests/villain.rs	Standalone libtest-mimic harness that enumerates villain tests and runs each in its own VM with per-test logging.
vmm_tests/virtio_villain_tests/src/villain.rs	TSV parsing + serial marker verdict scanning, with unit tests.
vmm_tests/virtio_villain_tests/src/run.rs	VM bring-up and “kitchen-sink” virtio device attachment, then serial log scanning.
vmm_tests/virtio_villain_tests/src/lib.rs	Public module surface for the new test runner crate.
vmm_tests/virtio_villain_tests/src/known_failures.rs	Central list of known-failing villain tests that are marked ignored.
vmm_tests/virtio_villain_tests/Cargo.toml	Defines the crate and its custom harness = false libtest-mimic test target.
petri/src/vm/openvmm/construct.rs	Allows a provided prebuilt_initrd to override firmware-provided initrd (needed for villain PID1 initramfs).
petri/src/tracing.rs	Adds new_log_source() to create additional log roots without reinstalling the global subscriber.
flowey/flowey_lib_hvlite/src/resolve_virtio_villain.rs	Flowey node to resolve virtio-villain guest artifacts (local override or GitHub release).
flowey/flowey_lib_hvlite/src/lib.rs	Exposes new Flowey nodes for virtio-villain build/resolve.
flowey/flowey_lib_hvlite/src/build_nextest_virtio_villain_tests.rs	Builds and archives the virtio-villain nextest suite for toolchain-free execution.
flowey/flowey_lib_hvlite/src/_jobs/run_virtio_villain_tests.rs	Local Flowey job to build OpenVMM, resolve artifacts, and run the suite end-to-end.
flowey/flowey_lib_hvlite/src/_jobs/mod.rs	Registers new virtio-villain job modules.
flowey/flowey_lib_hvlite/src/_jobs/consume_and_test_nextest_virtio_villain_archive.rs	CI job to unpack archive and run tests on KVM test machines, publishing JUnit + logs.
flowey/flowey_lib_hvlite/src/_jobs/cfg_versions.rs	Bumps OPENVMM_DEPS and wires resolve_virtio_villain config to that version.
flowey/flowey_hvlite/src/pipelines/virtio_villain_run.rs	Adds cargo xflowey virtio-villain-run pipeline entrypoint.
flowey/flowey_hvlite/src/pipelines/mod.rs	Registers the new pipeline subcommand.
flowey/flowey_hvlite/src/pipelines/checkin_gates.rs	Integrates build+consume split into PR gates, adding a dedicated virtio-villain CI job.
ci-flowey/openvmm-pr.yaml	Flowey-generated ADO pipeline wiring for the new archive and test job.
Cargo.toml	Adds vmm_tests/virtio_villain_tests to workspace members.
Cargo.lock	Adds lockfile entries for the new crate and deps.
.github/workflows/openvmm-pr.yaml	Flowey-generated GitHub workflow updates to run the new job and publish artifacts.
.github/workflows/openvmm-pr-release.yaml	Flowey-generated release PR workflow updates to include the new job.
.github/workflows/openvmm-ci.yaml	Flowey-generated CI workflow updates to include the new job and artifact wiring.
.config/nextest.toml	Adds per-package overrides (slow-timeout + threads-required) for virtio-villain tests.

Comments suppressed due to low confidence (4)

vmm_tests/virtio_villain_tests/src/known_failures.rs:55

• Known-failure reasons currently include a placeholder (microsoft/openvmm#TODO). This reads like a real issue link but isn't actionable; it’s better to either link a real tracking issue or make the TODO explicit without looking like a PR/issue reference.

    KnownFailure {
        name: "P0003",
        reason: "virtio-blk packed descriptor list exceeding queue size wedges \
                 the device (microsoft/openvmm#TODO)",
    },

vmm_tests/virtio_villain_tests/src/known_failures.rs:60

• Known-failure reason includes placeholder (microsoft/openvmm#TODO). Replace with a real issue link or an explicit TODO that doesn't look like an issue reference.

    KnownFailure {
        name: "T0001",
        reason: "virtio-blk self-looping descriptor chain hangs the virtio \
                 worker unrecoverably (microsoft/openvmm#TODO)",
    },

vmm_tests/virtio_villain_tests/src/known_failures.rs:65

• Known-failure reason includes placeholder (microsoft/openvmm#TODO). Replace with a real issue link or an explicit TODO that doesn't look like an issue reference.

    KnownFailure {
        name: "T0002",
        reason: "virtio-blk descriptor chain exceeding queue size hangs the \
                 virtio worker unrecoverably (microsoft/openvmm#TODO)",
    },

vmm_tests/virtio_villain_tests/src/known_failures.rs:70

• Known-failure reason includes placeholder (microsoft/openvmm#TODO). Replace with a real issue link or an explicit TODO that doesn't look like an issue reference.

    KnownFailure {
        name: "T0003",
        reason: "virtio-blk out-of-bounds descriptor `next` index hangs the \
                 virtio worker unrecoverably (microsoft/openvmm#TODO)",
    },

[Copilot]

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

vmm_tests/virtio_villain_tests/src/known_failures.rs:49

• The reason strings in KNOWN_FAILURES still contain placeholder issue links (microsoft/openvmm#TODO). Since ignored tests are intended to track product bugs, it’s important that each entry links to a real issue so the skip list doesn’t become stale.

pub const KNOWN_FAILURES: &[KnownFailure] = &[
    KnownFailure {
        name: "B0002",
        reason: "virtio-blk sector*512+data_len 64-bit wrap wedges the device \
                 (microsoft/openvmm#TODO)",

vmm_tests/virtio_villain_tests/src/villain.rs:50

• parse_tsv silently maps a missing/malformed device_id column to 0 (unwrap_or("0x0000") + unwrap_or(0)). That can hide issues with a corrupted/incorrect tests.tsv and make debugging harder. Since this is test metadata, failing fast with a line-specific error would be more actionable.

        let device_id = cols.next().unwrap_or("0x0000");
        let device_id = device_id
            .strip_prefix("0x")
            .and_then(|h| u16::from_str_radix(h, 16).ok())
            .unwrap_or(0);

[github-actions]

23 Petri tests failed (0 unstable)