virt_kvm: Fix synic message delivery check#4016
Open
smalis-msft wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a logic bug in KVM x86_64 SynIC message delivery gating so that pending SynIC messages are only attempted when SynIC is globally enabled and the message page (SIMP) is enabled.
Changes:
- Correct the early-return condition in
try_deliver_synic_messagesto require bothSCONTROL.enabledandSIMP.enabled.
smalis-msft
added
the
backport_1.8.2607
jstarks
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's unlikely this ever matters, since these two flags probably always get changed together, but just to be safe, fix this check.