virt_kvm: Validate MSR accesses#4015
Open
smalis-msft wants to merge 1 commit into
Open
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the KVM MSR read/write paths by validating that KVM_GET_MSRS / KVM_SET_MSRS actually process the full set of requested MSR entries, rather than silently accepting partial completion.
Changes:
- Add a new
Error::IncompleteMsrs { ... }variant that reports partial MSR processing (including the first unprocessed MSR and whether the operation was a write). - Update
Processor::get_msrsto check the returned “completed” count and error out if it’s less than requested. - Update
Processor::set_msrsto check the returned “completed” count and error out if it’s less than requested.
smalis-msft
added
the
backport_1.8.2607
Member
|
Do we think this is hitting somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kvm_get/set_msrs return the number of MSRs they were able to process. We should be validating that all of our requested MSRs do in fact get processed.