netvsp: adding MANA VF keepalive diagnostic traces#3938
Open
erfrimod wants to merge 1 commit into
Open
Conversation
erfrimod
commented
Jul 14, 2026
Contributor
- Tracing keepalive capabilities
- Tracing network settings save and number of saved MANA devices
- Adding debug traces for VFIO missing saved state
- Tracing keepalive mode, enablement, and saved state prior to NIC creation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional diagnostic tracing around MANA VF keepalive and network settings save/restore flows in Underhill (OpenHCL), improving observability during servicing and NIC creation.
Changes:
- Log keepalive mode/enablement, saved-state presence, and DMA client mode prior to Underhill NIC creation.
- Add traces for servicing-state resolution per NIC (including counts of saved MANA devices).
- Improve netvsp/VFIO traces for restore vs. new-device creation and successful keepalive state save, plus add save instrumentation and a saved-count trace.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openhcl/underhill_core/src/worker.rs | Adds info-level traces for keepalive inputs prior to NIC creation and for resolving servicing saved state per NIC. |
| openhcl/underhill_core/src/emuplat/netvsp.rs | Adds/extends VFIO device creation/restore traces and logs successful keepalive state save. |
| openhcl/underhill_core/src/dispatch/mod.rs | Adds servicing-request capability flag traces and instruments/logs network settings save with saved-device counts. |
Contributor
Author
|
Validated on tip:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.